Skip to content

Backlog/v12 log input exposure - #2469

Merged
AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_log_input_exposure
Aug 14, 2026
Merged

Backlog/v12 log input exposure#2469
AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_log_input_exposure

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@AlexSanchez-bit
AlexSanchez-bit force-pushed the backlog/v12_log_input_exposure branch from 6eb5262 to 77d5646 Compare August 14, 2026 17:48
@github-actions

Copy link
Copy Markdown

🛑 AI review — Sensitive area, extra care recommended

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. Review carefully before merging.

🛑 architecture (gemini-3-flash-lite) — high/critical — please review

Summary: Installer template modification introduces breaking changes to ingestion auth and changes the installer configuration.

  • high installer/templates/front-end.go:35 — Changes to ingestion authentication/headers (/ingest) without backwards-compatibility consideration may break existing connectors or agents. Installer modifications are a Tier 3 critical path.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Nginx configuration logic error in request validation for /ingest endpoint.

  • high installer/templates/front-end.go:41 — Inverted logic for connector key validation. If $connector_key_header is empty (= ""), $valid_request is set to 1 instead of failing, which means requests without a connector key are incorrectly treated as valid candidates for subsequent connector header checks.

🛑 security (gemini-3-flash-lite) — high/critical — please review

Summary: Nginx configuration changes in installer template touch authentication and routing logic for the ingest endpoint.

No findings.

🔴 go-deps — pending updates

🔍 Discovered 30 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/events:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/rule-flood-guard:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/stats:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/feeds:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/alerts:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./plugins/aws:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

  📁 ./backend:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.28

❌ Please update dependencies before merging.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

the needed check is X-Connector-Key, X-Connector-Id, X-Connector-Type valid toghether or Utm-Api-Key so having connector id is valid for subsequent validations which will be checking conection type and id or api key

@AlexSanchez-bit
AlexSanchez-bit merged commit 5e4c258 into release/v12.0.0 Aug 14, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_log_input_exposure branch August 14, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant