Repository navigation
Conversation
6 of 9 tasks
mtalvi
marked this pull request as ready for review
November 12, 2026 14:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A documented
make saw-restartpreviously calledvirtctl restart. Both original VMs and a fresh control were force-terminated after the implicit 30-second grace. Raising grace to 180 seconds alone was insufficient: both controls again expired and were markedDestroyed. Guest journals show shutdown reached filesystem unmounting; the exact blocked component remains unidentified. Guest-initiated poweroff completed naturally on both controls, with filesystem sync/unmount and console power-down evidence.Change
saw-restartand confirmedsaw-restart-pendingto use the existing guest SSH path forsudo systemctl poweroff. RequirerunStrategy: Always, wait for a different Running VMI with the updated mounted inputs, and report boot install/apply as a separate step. Guest access failure returns an error without falling back to host termination. Existing disks and sandbox volumes remain in place.Also set a configurable 180-second VMI termination grace. This gives other termination paths more time; it is not a demonstrated fix for the host-triggered shutdown stall. The supported restart path adopts the updated template for existing VM instances.
Refs #161 and the release gate in #157. Credential persistence is corrected separately in #162; the public interceptor pin stays in #160. The original damaged Podman catalog remains preserved, with cause/onset unproven. No database repair, package upgrade or journal-mode change is included.
Validation:
8001cc7c6454bf5398a6ea83065174af0c087a06, including Python 3.12 and 3.14.make saw-restartpassed on both existing controls from combined deployment0abf643dcd0de422bd69b91404ef373e8a1d5827. C naturally powered down at 14:52:34 UTC, D at 14:52:38 UTC on November 12. Both consoles confirm filesystem sync, all filesystems unmounted and power down; virt-handler reportsShutoff reason Shutdown. Neither grace expiry norDestroyedoccurred. Different Running VMIs were observed, both grace180.ok. Existing disks/volumes were preserved, with no package/database/journal-mode changes. Obsolete old-code install/reconcile work was stopped before the test without persistently disabling units; the replacements run normal boot install/apply.The supported operator restart path is validated and ready for review. Boot apply/inference acceptance for the separate credential correction remains tracked in #161/#162 and the #160 release gate. The generic host-triggered shutdown stall and original catalog damage's cause remain unresolved; this PR does not claim to fix those other termination paths. Nothing has been merged.
Further combined-source documented restarts also completed naturally at15:21:31 UTC (C) and15:22:16 (D), with powerdown/unmount evidence and no expiry/Destroyed. The restart correction does not establish data preservation: #165 separately records the existing installer automatically replacing D’s CUDA workspace after an earlier boot. #160 rollout remains held for that data-preservation fix; it is being handed off at the operator’s request.