Repository navigation
Add gitops.argoRBAC config key for full ArgoCD RBAC override - #754
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow overriding the entire ArgoCD .spec.rbac field via a YAML string
in the patterns-operator-config ConfigMap. When gitops.argoRBAC is set
and contains valid YAML, the parsed ArgoCDRBACSpec is used directly and
gitops.additionalArgoAdmins is ignored. On parse error, a warning is
logged and the operator falls back to the default RBAC configuration.
Tested with:
main:
gitops:
argoRBAC: |
defaultPolicy: role:readonly
policy: |-
g, system:cluster-admins, role:admin
g, mortaccitua, role:admin
g, cluster-admins, role:admin
g, admin, role:admin
Got:
oc get -n vp-gitops argocd vp-gitops -o jsonpath='{.spec.rbac}' | jq .
{
"defaultPolicy": "role:readonly",
"policy": "g, system:cluster-admins, role:admin\ng, mortaccitua, role:admin\ng, cluster-admins, role:admin\ng, admin, role:admin"
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding the entire ArgoCD .spec.rbac field via a YAML string
in the patterns-operator-config ConfigMap. When gitops.argoRBAC is set
and contains valid YAML, the parsed ArgoCDRBACSpec is used directly and
gitops.additionalArgoAdmins is ignored. On parse error, a warning is
logged and the operator falls back to the default RBAC configuration.