Remove SwiftNIO - #203
Open
0xTim wants to merge 11 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 2606 2567 -39
=========================================
- Hits 2606 2567 -39
🚀 New features to boost your workflow:
|
Contributor
|
@0xTim Love this! Just a note, I believe my #202 PR enables conditional nio removal but without requiring a breaking change. Not sure if it makes sense to merge #202 first, then layer #203 on top as the breaking change. If you like that idea, please let me know, I'm happy to look into how the two approaches could work together |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all the future APIs and the
EventLooprequirement from theDatabase. This allows us to remove NIO entirely from the package. An alternative to #202, opening for discussion for now as this is obviously a breaking change but could form the basis for Fluent 5. I haven't gone down the full modernisation route of turning on all the flags, removing imports etc as that can be done in future PRs.