Skip to content

return object from hook should be memoized #4

Open

Description

@pocesar

useMemo on

return {
stream,
error,
};
so you can use the object like:

const media = useUserMedia()

useEffect(() => {
}, [media]) // media is stable, since it's memoized

Activity

  1. vardius commented on Sep 15, 2019

    @vardius
    Owner

    Thanks @pocesar, for pointing this out,
    Do you want to create a pull request ?

  2. vardius commented on Apr 26, 2020

    @vardius
    Owner

    Why not memoize when necessary? At the upper scope:

    const media = React.useMemo(useUserMedia, [])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions