Skip to content

Use atomic rename on macos - #972

Merged
caesay merged 1 commit into
developfrom
cs/mac-apply-improvements
Jul 1, 2026
Merged

caesay merged 1 commit into
developfrom
cs/mac-apply-improvements

Conversation

@caesay

@caesay caesay commented Jul 1, 2026

Copy link
Copy Markdown
Member

Closes #966

@codecov

codecov Bot commented Jul 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.02985% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.93%. Comparing base (3ec28c2) to head (b72d385).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/bins/src/commands/apply_osx_impl.rs 94.02% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #972      +/-   ##
===========================================
+ Coverage    51.75%   51.93%   +0.18%     
===========================================
  Files          125      125              
  Lines        13528    13593      +65     
  Branches       595      595              
===========================================
+ Hits          7001     7060      +59     
- Misses        6379     6385       +6     
  Partials       148      148              
Flag Coverage Δ
nodejs 2.04% <0.00%> (-0.02%) ⬇️
rust 50.99% <76.11%> (+0.15%) ⬆️
vpk 23.13% <67.64%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caesay
caesay merged commit 7b3d615 into develop Jul 1, 2026
49 checks passed
@caesay
caesay deleted the cs/mac-apply-improvements branch July 1, 2026 23:08
This was referenced Sep 21, 2026
This was referenced Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate "Recent App" icons in Dock on MacOS

1 participant