Repository navigation
fix(state-pg): setIfNotExists TTL expiry - #636
Merged
bensabic merged 2 commits intoJul 15, 2026
Merged
Conversation
Contributor
|
@Zygimantass is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
bensabic
force-pushed
the
codex/state-pg-set-if-not-exists-ttl
branch
from
July 15, 2026 03:05
d973328 to
0870b6d
Compare
bensabic
marked this pull request as ready for review
July 15, 2026 03:06
bensabic
changed the title
bensabic
approved these changes
Jul 15, 2026
patrick-chinchill
added a commit
to Chinchill-AI/chat-sdk-python
that referenced
this pull request
Sep 30, 2026
…ion-owned schemas (#240) PostgresStateAdapter.set_if_not_exists now uses upstream's conditional upsert (ON CONFLICT DO UPDATE ... WHERE expires_at <= now() RETURNING), so expired dedupe/lease rows are reclaimed atomically; live and permanent rows are never overwritten. Ports upstream d88789c9 (vercel/chat#636, chat@4.35.0) and ea025af7 (vercel/chat#913, chat@4.41.0). New opt-in auto_create_schema=False (keyword-only; default True) skips DDL and runs a read-only table/privilege/sequence probe, raising chat_sdk.StateSchemaError on a missing table or grant. New exports: POSTGRES_SCHEMA_STATEMENTS, StateSchemaError; README documents the migration SQL. Divergences (docs/UPSTREAM_SYNC.md): StateSchemaError(ChatError) instead of plain Error; connect() serialized on an asyncio.Lock (queued callers retry); adapter-owned asyncpg pool closed on a failed connect() to avoid leaking 10 connections per retry. Consumer impact: Postgres-backed dedupe and leases recover after expiry without cleanup; no schema change; defaults unchanged. Tests: mock pool no longer reclaims under DO NOTHING; injectable mock clock; opt-in live suite via POSTGRES_TEST_URL. Closes #240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Postgres state adapter so
setIfNotExists()can claim a cache key whose existing row has expired.Previously the method used
ON CONFLICT DO NOTHING, so an expired row inchat_state_cachestill blocked acquisition until a separate cleanup deleted it. That diverged from the memory adapter behavior and from the expected lease semantics for cache-backed coordination.The new query keeps active rows protected, but replaces rows whose
expires_atis in the past.Validation
pnpm --filter @chat-adapter/state-pg testpnpm --filter @chat-adapter/state-pg typecheckpnpm exec ultracite check packages/state-pg/src/index.ts packages/state-pg/src/index.test.ts