Skip to content
This repository was archived by the owner on Oct 20, 2026. It is now read-only.

Bug Fix Round and Updates - #719

Merged
dominiksipowicz merged 4 commits into
mainfrom
kib-deps
Mar 24, 2022
Merged

dominiksipowicz merged 4 commits into
mainfrom
kib-deps

Conversation

@okbel

@okbel okbel commented Mar 23, 2022 •

Copy link
Copy Markdown
Contributor
  • This PR adds a missing dependency for Kibo Commerce Add to cart throwing 500 error #682
  • removed dead and unused code
  • refactored how we handle missing pages. It's now returning 404 instead of throwing on the build. This is something we could discuss because there are valid 404 (even on build) and there are definitely worrying situations when something should be and is not present. This will fix 404 page is not loading #468
  • refactored types for pages. I get flaky errors on a few builds around those types returning never.
next-commerce:build: (node:919) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'pages' of undefined
next-commerce:build: TypeError: Cannot read property 'pages' of undefined
next-commerce:build: (node:926) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'collections' of undefined

@okbel okbel added the bug Something isn't working label Mar 23, 2022
@okbel
okbel requested a review from dominiksipowicz March 23, 2022 16:05
@vercel

vercel Bot commented Mar 23, 2022 •

Copy link
Copy Markdown
Contributor

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

commerce-local – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-local/HV8gw9DACvtkr1M3MtHK4rvfyYWV
✅ Preview: https://commerce-local-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-shopify – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-shopify/3j4QjikhaXPeyvAM8EbBEJ8gfzdv
✅ Preview: https://commerce-shopify-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-ordercloud – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-ordercloud/FgkEmNk1Nt9y6zPX4MwDJQJ7QVJA
✅ Preview: https://commerce-ordercloud-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-bigcommerce – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-bigcommerce/AFmbQx7t6K5Jbq4B5CYzyt4VjSda
✅ Preview: https://commerce-bigcommerce-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-commercejs – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-commercejs/7Gy6X8UecxuFY9NurUr8PW8hMEtb
✅ Preview: https://commerce-commercejs-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-spree – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-spree/6ZENudCA5SaJD6cWdj9yMUCLJJrt
✅ Preview: https://commerce-spree-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-kibocommerce – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-kibocommerce/45zcJxttmWrRYWFc6TkQJadQVCKh
✅ Preview: https://commerce-kibocommerce-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-vendure – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-vendure/HQaHBAaz5K6Y6Cpvz7c9kXUYaSo6
✅ Preview: https://commerce-vendure-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-swell – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-swell/FEB6bkCqUHcxxX9SEXkZo9zCg9j8
✅ Preview: https://commerce-swell-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-saleor – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-saleor/9isuCczbFgeArMEv1jowTF6gEAxx
✅ Preview: https://commerce-saleor-git-kib-deps-vercel-solutions-vtest314.vercel.app

@vercel
vercel Bot temporarily deployed to Preview – commerce-saleor March 24, 2022 09:54 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-saleor March 24, 2022 10:12 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-shopify March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-vendure March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-commercejs March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-kibocommerce March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-spree March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-local March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-bigcommerce March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-saleor March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-swell March 24, 2022 11:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – commerce-ordercloud March 24, 2022 11:03 Inactive
@okbel okbel changed the title Missing dependency for Kibo Commerce Bug Fix Round and Updates Mar 24, 2022
@dominiksipowicz
dominiksipowicz merged commit 52b25b8 into main Mar 24, 2022
@dominiksipowicz
dominiksipowicz deleted the kib-deps branch March 24, 2022 11:42
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 25, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 25, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 26, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 26, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@ashishkpaul

Copy link
Copy Markdown

Hello sir in spree/commerce its not fetching the products from menu links. is there any solution
i tried app link https://commerce-spree-git-kib-deps-vercel-solutions-vtest314.vercel.app/
and also on the fresh deployment showing the same results

spree-vercel

loan-laux pushed a commit to TrellisCommerce/next-commerce-bigcommerce that referenced this pull request May 11, 2023
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
djahlor pushed a commit to djahlor/commerce that referenced this pull request Apr 23, 2025
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
anhdd-kuro pushed a commit to anhdd-kuro/vercel_commerce that referenced this pull request Apr 8, 2026
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
babakhalid pushed a commit to babakhalid/Yomake-Commerce-Template that referenced this pull request Oct 3, 2026
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>

This branch was previously deployed

10 inactive deployments
Preview – commerce-ordercloud — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-swell — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-saleor — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-bigcommerce — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-local — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-kibocommerce — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-spree — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-commercejs — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-vendure — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Preview – commerce-shopify — 7f861d83 Deployed Mar 24, 2022 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 page is not loading

3 participants