Repository navigation
Suppress recovered rapid heap growth warnings - #2472
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49930cc7d1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
49930cc to
342d1b7
Compare
|
Addressed the inline feedback about restart baselines.
Verification after the update:
|
Summary
Rapid heap growth detectedby one memory-monitoring interval and only warn if heap remains more than 100MB above the pre-spike baseline.observedGrowthMBto distinguish the original spike from the sustained delta.deno.jsonandsrc/utils/version-constant.tsfrom0.1.817to0.1.818.Runtime evidence addressed
The production sample from #3200 showed a cold render/cache warmup spike from 99.16MB to 212.69MB, then recovery to 153.01MB on the next sample. This change suppresses that recovered one-interval spike but still alerts when the next sample remains over the 100MB sustained-growth threshold.
Test plan
deno test --no-check --allow-all src/utils/memory/profiler.test.tsdeno test --no-check --allow-all src/utils/version.test.ts src/utils/logger/logger.test.ts src/utils/memory/profiler.test.tsDENO_NO_PACKAGE_JSON=1 deno lint src/utils/memory/profiler.ts src/utils/memory/profiler.test.tsdeno check src/utils/memory/profiler.ts src/utils/memory/profiler.test.tsdeno task typecheckdeno task test:unitpassed: 2167 tests, 18661 steps.git pushpre-push checks passed: formatting, lint, typecheck, unit tests.Known repo gate
deno task verify:quickcurrently stops at pre-existinglint:cli-boundaryviolations incli/shared/server-startup.ts, unrelated to this diff.