fix doubled render call - #180
Merged
Merged
Conversation
vikashplus
reviewed
Sep 1, 2026
| render_cbk=self.mj_render if self.mujoco_render_frames else None) | ||
| # robot.step() above already rendered this tick when mujoco_render_frames is True | ||
| self._rendered_this_tick = self.mujoco_render_frames | ||
| return self.forward(**kwargs) |
Owner
There was a problem hiding this comment.
Won't it be better to extend forward
def _forward(self, render=True, **kwargs):
and step when it uses render it simply calls
self.forward(render=False, **kwargs)
It preserves the features and extends the functionality and can be a stronger design choice.
vikashplus
requested changes
Sep 1, 2026
vikashplus
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.