Repository navigation
feat(hmr): truncate list of files on hmr update - #21535
Merged
Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
bluwy
reviewed
Feb 2, 2026
left a comment
Member
There was a problem hiding this comment.
Even with 10, I think it could be quite long though if the file paths are really long for some projects. Maybe we should truncate it by checking the string length instead?
Also, I think we should also debug log the remaining file paths as it may be useful for debugging HMR issues.
ArnaudBarre
force-pushed
the
arnaud/hmr-truncate
branch
from
March 29, 2026 18:13
8c2398a to
1970e7e
Compare
ArnaudBarre
force-pushed
the
arnaud/hmr-truncate
branch
from
March 29, 2026 18:53
af1f031 to
1adad15
Compare
bluwy
approved these changes
Mar 30, 2026
sapphi-red
added
feat: hmr
p2-nice-to-have
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a long time since I wanted to do this. When I ran the codegen on my project, all the React files which imports the DB enums from it updates and the terminal a just a wall of useless text. I think truncating at 10 is a good tradeoff.
I can add a test in the hmr playground, but I'm not sure it's worth the 12 files to setup it up given how simple the code is.
Before:
After:
