Repository navigation
fix(module-runner): keep stack trace interception working when Object.prototype is frozen - #23073
Merged
sapphi-red merged 1 commit intoJul 27, 2026
Conversation
…t.prototype` is frozen `cloneCallSite` copied every own property of `CallSite.prototype`, including `constructor`, onto a plain object. When user code runs `Object.freeze(Object.prototype)`, that assignment throws `TypeError: Cannot assign to read only property 'constructor'` the first time `error.stack` is read, breaking any consumer of the `prepareStackTrace` sourcemap interceptor (vitest-dev/vscode#798). Clone onto a null-prototype object instead.
sapphi-red
added
p3-downstream-blocker
sapphi-red
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cloneCallSitecopies every own property ofCallSite.prototype, includingconstructor, onto a plain object. If user code ranObject.freeze(Object.prototype), that assignment throws on the firsterror.stackread, breaking theprepareStackTracesourcemap interceptor. This clones onto a null-prototype object instead.Fixes vitest-dev/vscode#798 (Vitest test collection crashing when
includeTaskLocationis enabled).