Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests failed in the CI/CD on my PR #23484. But, they pass repeatedly on my machine. Reviewing the logs it looks like this is happening to other people as well and it is a flake.
I believe the problem is that notifyRebuildComplete resolves on the first END. Moving reload inside expect.poll fixes the problem.
I can reproduce the flake by forcing the rebuild wait to resolve early. After this change tests still pass even when forcing the early resolve.
The time it takes the tests to run before vs. after is the same, so this does not hurt performance.
AI Use:
Qwen3 Coder 30B 4-bit suggested changes that I did not like. I consulted it but used nothing from it. I used Fable 5.1 to look through the log history to find the flake pattern and assist in the fix. I also used it to automate looping through tests. All English writing is my own :)