Skip to content

feat(browser): add option to take trace view dom snapshot only on failure - #10356

Closed
hi-ogawa wants to merge 10 commits into
vitest-dev:mainfrom
hi-ogawa:feat/trace-view-snapshot-option
Closed

hi-ogawa wants to merge 10 commits into
vitest-dev:mainfrom
hi-ogawa:feat/trace-view-snapshot-option

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented May 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

WIP

TODO

  • prototype
  • test
  • make __vitest_recordBrowserTrace fire-and-forget
  • measure recording overhead
  • change default
  • docs

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 2 commits May 15, 2026 16:36
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@netlify

netlify Bot commented May 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6b00bd
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6ad06a042f6c82317b576c4a
😎 Deploy Preview https://deploy-preview-10356--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa and others added 2 commits May 15, 2026 16:51
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@hi-ogawa hi-ogawa changed the title feat(browser): add option to take dom snapshot only on failure feat(browser): add option to take trace view dom snapshot only on failure May 15, 2026
@hi-ogawa

Copy link
Copy Markdown
Collaborator Author

I have measured a performance with this approach and this approach still has a cost for passing tests due to how it eagerly process stack trace on server side. So the different approach is now proposed in #10310 (comment). Closing this PR for now to start fresh.

@hi-ogawa hi-ogawa closed this Oct 16, 2026
@hi-ogawa
hi-ogawa deleted the feat/trace-view-snapshot-option branch October 16, 2026 02:20
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace View: Failure-Only Trace Recording

1 participant