Repository navigation
feat: add fakeTimers.fakeNodeBuiltins option - #11620
Closed
sheremet-va wants to merge 1 commit into
Closed
sheremet-va wants to merge 1 commit into
sheremet-va wants to merge 1 commit into
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Is this different from my pr? |
Member
Author
|
Lol, I didn't notice, let's just keep yours 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fakeTimers.fakeNodeBuiltins(defaultfalse) to fakenode:timersandnode:timers/promisestogether with the global timers. ESM named imports are updated throughsyncBuiltinESMExports; vm pools also re-sync their synthetic builtin modules.The module faking in the patched
@sinonjs/fake-timersnever ran before: the patch read__vitest_required__at module scope, before Vitest assigns it.Fixes #10871