Repository navigation
refactor(snapshot): unify review update with SnapshotState update - #11790
Merged
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
9 tasks
SnapshotState now returns the update it would write under -u when a snapshot mismatches, and the reviewer applies that instead of rebuilding one from the serialized error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hi-ogawa
force-pushed
the
snapshot-pending-update
branch
from
November 2, 2026 06:53
13e9ef4 to
b79708b
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
SnapshotState update
hi-ogawa
marked this pull request as ready for review
November 2, 2026 07:25
Member
…date # Conflicts: # packages/vitest/src/node/snapshot-review.ts
sheremet-va
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously, the interactive review in #11325 rebuilt each update from the serialized test error (trimmed
actual,meta,stacks[0]), even thoughSnapshotStatealready knew what the update should be for--update. The divergence can cause minor differences in how--updateand review mode apply updates.This PR makes
SnapshotStatereturn the update it would write under--update, so that the snapshot review can reuse it.