Skip to content

fix(browser): fix expect.element with message and remove redundant [ERROR] in trace steps - #11832

Merged
sheremet-va merged 9 commits into
mainfrom
poll-trace-name
Nov 4, 2026
Merged

sheremet-va merged 9 commits into
mainfrom
poll-trace-name

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Previously, browser mode ignored the message option of expect.element in trace step names, while Node's expect.poll steps include it. Browser steps also added [ERROR] to the name of a failed step, although the entry already records its status.

This PR includes the message in browser trace step names and drops [ERROR] from them. For example,

await expect.element(page.getByRole('heading'), { message: 'heading shown' }).toHaveTextContent('Welcome')
Before After
without message toHaveTextContent toHaveTextContent
with message toHaveTextContent heading shown (toHaveTextContent)
failed toHaveTextContent [ERROR] toHaveTextContent

Playwright trace event is label only without status semantics, so they still keep [ERROR] on failure.

hi-ogawa and others added 2 commits November 2, 2026 19:10
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 2, 2026

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 6c01b1d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6ae861c6a4fb6182d47320cc
😎 Deploy Preview https://deploy-preview-11832--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa changed the title feat(browser): align expect.element trace step names fix(browser): align expect.element trace step names Nov 2, 2026
@flakiness-io

flakiness-io Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
96c62b4 ❌ Failed 1 regressed · 31502 passed · 234 flaky · 1185 skipped 27 runs

1 regressed

🔥 win 10.0.26100 · main test/e2e/test/fs-module-cache-resiliency.test.ts:234 › parallel runs clearing an outdated cache do not fail

⚠️ 234 flaky

⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
…and 224 more

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

hi-ogawa and others added 3 commits November 4, 2026 13:38
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@hi-ogawa hi-ogawa changed the title fix(browser): align expect.element trace step names fix(browser): show expect.element message in trace steps Nov 4, 2026
@netlify

netlify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 5ba2e36
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6aeadf60325336a58f30e87b
😎 Deploy Preview https://deploy-preview-11832--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa and others added 2 commits November 4, 2026 16:20
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@hi-ogawa hi-ogawa changed the title fix(browser): show expect.element message in trace steps fix(browser): align expect.element trace step names Nov 4, 2026
@hi-ogawa hi-ogawa changed the title fix(browser): align expect.element trace step names fix(browser): fix expect.element with message and remove redundant [ERROR] in trace steps Nov 4, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@hi-ogawa
hi-ogawa marked this pull request as ready for review November 4, 2026 07:52
@hi-ogawa
hi-ogawa added this pull request to stack #11874 November 4, 2026 07:55
@sheremet-va
sheremet-va merged commit 1d115dc into main Nov 4, 2026
27 of 30 checks passed
@sheremet-va
sheremet-va deleted the poll-trace-name branch November 4, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants