Skip to content

fix(experimental): skip ambiguous expect.poll trace steps in concurrent tests - #11869

Merged
sheremet-va merged 2 commits into
mainfrom
trace-poll-concurrent
Nov 4, 2026
Merged

sheremet-va merged 2 commits into
mainfrom
trace-poll-concurrent

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Previously, experimental.traceTimeline could misattribute steps from the global expect.poll to the wrong failing test when tests ran with test.concurrent.

This PR skips expect.poll steps from the global expect by guarding them with the condition getRunningTests().size === 1.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 4, 2026

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 8fc8ee5
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6aea98ba0681174f1db19e7a
😎 Deploy Preview https://deploy-preview-11869--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@flakiness-io

flakiness-io Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
f45a57a ✅ Passed 31386 passed · 234 flaky · 1185 skipped 27 runs
⚠️ 234 flaky

⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
…and 224 more

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

@hi-ogawa hi-ogawa changed the title fix(experimental): skip ambiguous expect.poll steps fix(experimental): skip ambiguous expect.poll steps in concurrent tests Nov 4, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@hi-ogawa
hi-ogawa marked this pull request as ready for review November 4, 2026 03:03
@hi-ogawa hi-ogawa changed the title fix(experimental): skip ambiguous expect.poll steps in concurrent tests fix(experimental): skip ambiguous expect.poll trace steps in concurrent tests Nov 4, 2026

@sheremet-va sheremet-va left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but we should fix the concurrent tracking at some point...

@sheremet-va
sheremet-va merged commit f6ef4b0 into main Nov 4, 2026
30 checks passed
@sheremet-va
sheremet-va deleted the trace-poll-concurrent branch November 4, 2026 08:53
@hi-ogawa

hi-ogawa commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Ok, but we should fix the concurrent tracking at some point...

Created a follow-up issue #11875 The scope is quite big 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants