Repository navigation
fix(experimental): skip ambiguous expect.poll trace steps in concurrent tests - #11869
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hi-ogawa
marked this pull request as ready for review
November 4, 2026 03:03
expect.poll trace steps in concurrent tests
sheremet-va
approved these changes
Nov 4, 2026
sheremet-va
left a comment
Member
There was a problem hiding this comment.
Ok, but we should fix the concurrent tracking at some point...
Collaborator
Author
Created a follow-up issue #11875 The scope is quite big 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
experimental.traceTimelinecould misattribute steps from the globalexpect.pollto the wrong failing test when tests ran withtest.concurrent.This PR skips
expect.pollsteps from the globalexpectby guarding them with the conditiongetRunningTests().size === 1.