Skip to content

ci(create): warm up the monorepo cache check under every package manager - #3423

Merged
fengmk2 merged 1 commit into
mainfrom
claude/vite-plus-ci-failure-c6c672
Nov 10, 2026
Merged

ci(create): warm up the monorepo cache check under every package manager#3423
fengmk2 merged 1 commit into
mainfrom
claude/vite-plus-ci-failure-c6c672

Conversation

@wan9chi

@wan9chi wan9chi commented Nov 10, 2026

Copy link
Copy Markdown
Member

Summary

vp create monorepo (pnpm) and vp create monorepo (bun) have failed on every run since #3418 bumped vite-task to cb1ea8d. The "Verify cache (monorepo only)" step expects 100% cache hits on the second vp run ready but gets 40%:

[1] test-project#ready: $ vp check   → Cache miss: 'dist' added in 'packages/utils'
[2] utils#test: vp test              → Cache miss: 'dist' added in 'packages/utils'
[4] website#build: tsc               → Cache miss: 'dist' added in 'apps/website'

vite-task no longer skips dist entries in folder listings (voidzero-dev/vite-task#919). ready runs vp check && vp run -r test && vp run -r build, so vp check, vp test, and tsc list these folders before vp pack and vp build create dist/ there. The second run then sees the new entry and misses. The third run hits.

npm and yarn already got one extra warm-up for the packages/utils/node_modules/ miss (#1638), so they kept passing. This PR gives pnpm and bun the same warm-up and rewrites the step's comment to describe both causes.

#3418 didn't catch this because these jobs only run when create, template, or workflow files change.

Not included

This only fixes CI. A freshly created monorepo still needs three vp run ready runs to be fully cached. Fixing that is a separate change:

  • vp check, vp lint, vp fmt: oxlint and oxfmt skip gitignored folders, so the built-in cache config could add folder-entry exclusions for gitignored entries (!**/dist, !**/node_modules). !**/dist/** would be wrong: type-aware checks read other packages' dist/*.d.ts.
  • vp test: Vitest 5 doesn't read .gitignore and its default exclude doesn't cover dist, so it does search dist for test files.
  • tsc in the website's build script: a third-party command, so only per-package config can exclude dist.

Test plan

  • vp create monorepo passes for pnpm, npm, yarn, and bun

🤖 Generated with Claude Code

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Nov 10, 2026
@wan9chi Graphite App

wan9chi commented Nov 10, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 10, 1:58 PM UTC: The merge label 'auto-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 10, 2:32 PM UTC: wan9chi added this pull request to the Graphite merge queue.
  • Nov 10, 2:53 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'done', 'CLI snapshot test (Windows, shard 1/3)', 'CLI snapshot test (Windows, shard 2/3)').

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://claude-vite-plus-ci-failure-c6c672-viteplus-dev.voidzero-docs.workers.dev (commit 91e5924)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗		 https://e5d8c23a-viteplus-dev.voidzero-docs.workers.dev 91e5924 2026-11-10T14:34:31.803Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗		 https://104138e4-viteplus-dev.voidzero-docs.workers.dev 36f93e2 2026-11-10T14:06:44.420Z Visit the dashboard ↗

@wan9chi
ci(create): warm up the monorepo cache check under every package mana…
91e5924 
…ger (#3423)

## Summary

`vp create monorepo (pnpm)` and `vp create monorepo (bun)` have failed on every run since #3418 bumped vite-task to cb1ea8d. The "Verify cache (monorepo only)" step expects 100% cache hits on the second `vp run ready` but gets 40%:

```
[1] test-project#ready: $ vp check   → Cache miss: 'dist' added in 'packages/utils'
[2] utils#test: vp test              → Cache miss: 'dist' added in 'packages/utils'
[4] website#build: tsc               → Cache miss: 'dist' added in 'apps/website'
```

vite-task no longer skips `dist` entries in folder listings (voidzero-dev/vite-task#919). `ready` runs `vp check && vp run -r test && vp run -r build`, so `vp check`, `vp test`, and `tsc` list these folders before `vp pack` and `vp build` create `dist/` there. The second run then sees the new entry and misses. The third run hits.

npm and yarn already got one extra warm-up for the `packages/utils/node_modules/` miss (#1638), so they kept passing. This PR gives pnpm and bun the same warm-up and rewrites the step's comment to describe both causes.

#3418 didn't catch this because these jobs only run when create, template, or workflow files change.

## Not included

This only fixes CI. A freshly created monorepo still needs three `vp run ready` runs to be fully cached. Fixing that is a separate change:

- `vp check`, `vp lint`, `vp fmt`: oxlint and oxfmt skip gitignored folders, so the built-in cache config could add folder-entry exclusions for gitignored entries (`!**/dist`, `!**/node_modules`). `!**/dist/**` would be wrong: type-aware checks read other packages' `dist/*.d.ts`.
- `vp test`: Vitest 5 doesn't read `.gitignore` and its default `exclude` doesn't cover `dist`, so it does search `dist` for test files.
- `tsc` in the website's `build` script: a third-party command, so only per-package config can exclude `dist`.

## Test plan

- [ ] `vp create monorepo` passes for pnpm, npm, yarn, and bun

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app
graphite-app Bot force-pushed the claude/vite-plus-ci-failure-c6c672 branch from 36f93e2 to 91e5924 Compare November 10, 2026 14:33
@graphite-app graphite-app Bot removed the auto-merge label Nov 10, 2026
@fengmk2
fengmk2 merged commit 798c7a9 into main Nov 10, 2026
152 of 155 checks passed
@fengmk2
fengmk2 deleted the claude/vite-plus-ci-failure-c6c672 branch November 10, 2026 15:08
@fengmk2 fengmk2 mentioned this pull request Nov 10, 2026
Merged
fengmk2 added a commit that referenced this pull request Nov 11, 2026
@voidzero-guard @fengmk2 @claude
release: v1.6.0 (#3426)
fd6edb8 
Vite+ 1.6.0 caches `vp run` tasks that rewrite files they read, previews
runs with `vp run --dry-run` and JSON output, lets `vp check
--continue-on-error` report every failed check, and sets `VP_USER_AGENT`
for the tools that `vp` starts.

### Features

- `vp run` caches tasks that read files they also write, such as `tsdown
--exports` rewriting `package.json` or `tsc --incremental` reading and
writing `tsconfig.tsbuildinfo`. The files a task writes, and folders
that hold only those files, may be missing on the next run, as on a
fresh clone, and a cache hit restores them with the task's outputs,
including the symbolic links the task created
([docs](https://viteplus.dev/guide/automatic-data-tracking#rebuildable-inputs))
([vite-task#913](voidzero-dev/vite-task#913),
[vite-task#914](voidzero-dev/vite-task#914),
[vite-task#915](voidzero-dev/vite-task#915),
[vite-task#916](voidzero-dev/vite-task#916),
[vite-task#917](voidzero-dev/vite-task#917),
[vite-task#918](voidzero-dev/vite-task#918)), by
@wan9chi.
- `vp run --dry-run` shows each command that a run would start and
whether it would hit the cache, without running anything or writing to
the cache. `vp run --json` prints every package and task in the
workspace, and `vp run --dry-run --json` prints the run plan with each
step's cache status, as one JSON document for scripts, CI, and coding
agents. `vp run -v` lists every change behind a cache miss, including
each changed input file, and `-vv` also lists the unchanged inputs and
the outputs that a hit restores
([docs](https://viteplus.dev/guide/run#dry-runs-and-json-output))
([vite-task#948](voidzero-dev/vite-task#948),
[vite-task#960](voidzero-dev/vite-task#960),
[vite-task#961](voidzero-dev/vite-task#961),
[vite-task#963](voidzero-dev/vite-task#963),
[vite-task#966](voidzero-dev/vite-task#966),
[vite-task#967](voidzero-dev/vite-task#967),
[vite-task#968](voidzero-dev/vite-task#968),
[vite-task#969](voidzero-dev/vite-task#969)), by
@wan9chi.
- `vp check --continue-on-error` runs the remaining enabled checks after
a failure, so one run reports formatting, lint, and type errors
together, and exits with the status of the first failed check. Without
the flag, `vp check` still stops at the first failed check
([#3367](#3367)), by
@chbaefront.
- `vp`, `vpr`, and `vpx` set `VP_USER_AGENT=vp/<version>` for their
child processes, so tools can detect that Vite+ started them. When the
global CLI delegates to a project's local CLI, the local version is
reported ([docs](https://viteplus.dev/guide/global-cli#vp-user-agent))
([#1958](#1958)), by
@fengmk2.
- First part of `VP_ENV_FORBIDDEN=1`, for systems such as NixOS that
provide Node.js and package managers themselves: with it set, Vite+
never downloads a Node.js or package-manager version, shims and `vpx`
use only the system tools on `PATH`, and installers and `vp upgrade` use
the system `node` and `pnpm` for Vite+'s own dependencies. In this
release, commands that delegate to a package manager, such as `vp
install` and `vp run`, fail with `DisabledByEnvForbidden` while it is
set. A follow-up change is planned to cover them and document the
variable ([#3233](#3233)),
by @myuron.
- Upgrade the bundled Oxfmt and Oxlint
([#3416](#3416)), by
@voidzero-guard[bot]:
- `oxfmt@0.76.0` to `oxfmt@0.78.0`. Oxfmt formats Vue files with its own
formatter instead of Prettier, so the output for Vue templates can
change. It also fixes Tailwind class sorting in several layouts, Less
escapes and `%` selectors, and TypeScript in Astro files.
- `oxlint@1.91.0` to `oxlint@1.93.0` and `oxlint-tsgolint@7.0.2005` to
`oxlint-tsgolint@7.0.2006`. `no-redeclare` gets an
`ignoreDeclarationMerge` option, and `promise/prefer-catch` offers a
suggestion.
- Oxlint and Oxfmt resolve an unset or relative `root` in
`vite.config.ts` from the directory of the config file instead of the
current directory, so editor integrations in multi-root workspaces load
the correct project.
- Vite+ installs its own dependencies during setup and `vp upgrade` with
`pnpm@10.34.9` (was `pnpm@10.34.7`).
- The new Oxfmt and Oxlint can flag code that passed before. If your CI
runs `vp check`, run `vp check --fix --continue-on-error` after you
upgrade: it formats files, applies the available lint fixes, formats
again, and reports every error that remains. For example,
`unicorn/prefer-type-error` now also reports a `throw` in an `if` branch
without braces, and this command rewrites it.

### Fixes & Enhancements

- While a Vite+ spinner is visible, such as `Installing global packages`
in `vp install -g`, Vite+ hides the cursor and discards typed keys.
Pressing Enter no longer leaves copies of the spinner row, and typed
text no longer runs in the shell after the command ends. Ctrl+C during a
spinner now ends the command with the usual signal status instead of
exit code 0, and the global package spinners show the elapsed time
([#3373](#3373),
[#3417](#3417)), by
@jong-kyung and @fengmk2.
- `vp run` loads a package's `vite.config.*` only when the run reaches
one of that package's tasks. A run in one package no longer waits for
the configs of other packages, a broken config in another package no
longer fails it, and `vp run <task>` in a package that does not define
the task reports `Task "<task>" not found` instead of another package's
config error
([vite-task#944](voidzero-dev/vite-task#944),
[vite-task#988](voidzero-dev/vite-task#988)), by
@wan9chi.
- `vp run nope#build`, where no workspace package has the name `nope`,
fails with `Package 'nope' not found in the workspace` and exits with
code 1, instead of running nothing and exiting with code 0. A short name
that matches several scoped packages fails as ambiguous
([vite-task#984](voidzero-dev/vite-task#984)),
by @wan9chi.
- Folder listings no longer skip entries named `dist`, so a `dist`
folder that appears or disappears in a folder a task lists makes the
next run a cache miss. Exclusions in a task's `input`, such as
`"!dist/**"`, now also apply to the folders that the task lists. In a
new monorepo from `vp create`, every task hits the cache from the third
`vp run ready`, because the first build creates the `dist` folders
([vite-task#919](voidzero-dev/vite-task#919),
[vite-task#941](voidzero-dev/vite-task#941)), by
@wan9chi.
- Fewer unnecessary cache misses and cache failures in `vp run`: on
Windows, files that a task deletes or moves are no longer among its
inputs. Tasks that read `node_modules/.vite/task-cache`, as Parcel and
Gatsby do, hit the cache. A task that writes outside the workspace
through `..`, like `cp -r dist ../site`, no longer fails with `Cache
update failed`
([vite-task#937](voidzero-dev/vite-task#937),
[vite-task#940](voidzero-dev/vite-task#940),
[vite-task#980](voidzero-dev/vite-task#980)), by
@wan9chi.
- A cache hit restores the symbolic links that a task's `output` globs
match as links, instead of dropping them
([vite-task#885](voidzero-dev/vite-task#885)),
by @jasonkuhrt.
- When several tasks become ready at the same time, `vp run` checks
their cache entries in parallel, so cache hits start sooner
([vite-task#982](voidzero-dev/vite-task#982)),
by @wan9chi.
- On macOS, task commands that use `sh` or `bash` behave as on Linux: a
`while read` loop with a redirect under `set -e` no longer exits the
script, an `EXIT` trap sees the exit status, so a failed task is no
longer reported as successful, and `$BASH` is set
([vite-task#939](voidzero-dev/vite-task#939)),
by @lifeiscontent.
- The helper files that `vp run` writes to the system temp directory go
in one folder that only the current user can write to, such as
`/tmp/vp_run-1000` on Linux. On Linux, a different Vite+ version run by
another user no longer fails
([vite-task#947](voidzero-dev/vite-task#947),
[vite-task#974](voidzero-dev/vite-task#974)), by
@wan9chi.
- A `getEnvs` query from `@voidzero-dev/vite-task-client` that matches
every name (`{ prefix: '' }` or `*`) returns nothing and no longer adds
every environment variable to the cache key
([vite-task#976](voidzero-dev/vite-task#976)),
by @wan9chi.
- `vp migrate` no longer writes package specs that the package manager
cannot resolve, such as a `@vitest/*` `catalog:` reference without a
catalog entry or a top-level catalog on Bun before 1.2.21. Bun projects
with an empty `workspaces` field get catalog references, and child
packages with a plain `vite-plus` range get the same concrete version as
the root when the project cannot use catalogs
([#3397](#3397)), by
@jong-kyung.
- `vp create` uses the package manager version that `VP_PACKAGE_MANAGER`
selects for the generated settings, the installation, and its summary.
Standalone pnpm projects get `packages: ['.']` in an existing
`pnpm-workspace.yaml` only for pnpm before 10.5.0
([#3197](#3197)), by
@evan-lc and @fengmk2.
- `vp` sends a `User-Agent` header on all HTTP requests, so Node.js
mirrors that reject requests without one, such as `mirrors.aliyun.com`,
work ([#3425](#3425)), by
@naokihaba.
- `vp env pin` prints `Updated` when it overwrites an existing
`.node-version` or `.nvmrc` file and `Created` when it writes a new one
([#3377](#3377)), by
@CheHyeonYeong.

### Docs

- Describe rebuildable inputs in the Automatic Data Tracking guide, and
dry runs, JSON output, and `-vv` in the `vp run` guide
([#3419](#3419),
[#3421](#3421)), by
@wan9chi.

### Chore

- Bump vite-task to `cb1ea8d`, with its user-facing changes listed
above, and list `--dry-run`, `--json`, and `-vv` in `vp run --help`
([#3418](#3418)), by
@wan9chi.
- The daily dependency upgrade also updates the pnpm version that the
installers pin, after it checks the release integrity
([#3407](#3407)), by
@fengmk2.
- Warm up the monorepo cache check in the `vp create` CI job under pnpm
and Bun ([#3423](#3423)),
by @wan9chi.
- Remove an unused CI job that the required `done` check did not cover
([#3403](#3403)), by
@jong-kyung.
- Remove an incorrect comment about export pattern order in the CLI
build script
([#3405](#3405)), by
@alexicum.

### Bundled Versions

| Tool | Version | Source | Changelog |
| --------------- | ---------- |
----------------------------------------------------------------------------------------------------
|
-----------------------------------------------------------------------------------------------------------------------------------------------
|
| vite | `8.3.7` |
[`5def936`](vitejs/vite@5def936)
| unchanged |
| rolldown | `1.2.18` |
[`f9a49d6`](rolldown/rolldown@f9a49d6)
| unchanged |
| oxc-node | `1.0.1` |
[`7ff14c3`](oxc-project/oxc-node@7ff14c3)
| unchanged |
| tsdown | `0.23.4` | [npm](https://npmx.dev/package/tsdown/v/0.23.4) |
unchanged |
| vitest | `5.1.0` | [npm](https://npmx.dev/package/vitest/v/5.1.0) |
unchanged |
| oxlint | `1.93.0` | [npm](https://npmx.dev/package/oxlint/v/1.93.0) |
[1.92.0](https://github.com/oxc-project/oxc/releases/tag/oxlint_v1.92.0),
[1.93.0](https://github.com/oxc-project/oxc/releases/tag/oxlint_v1.93.0)
|
| oxlint-tsgolint | `7.0.2006` |
[npm](https://npmx.dev/package/oxlint-tsgolint/v/7.0.2006) |
[7.0.2006](https://github.com/oxc-project/tsgolint/releases/tag/v7.0.2006)
|
| oxfmt | `0.78.0` | [npm](https://npmx.dev/package/oxfmt/v/0.78.0) |
[0.77.0](https://github.com/oxc-project/oxc/releases/tag/oxfmt_v0.77.0),
[0.78.0](https://github.com/oxc-project/oxc/releases/tag/oxfmt_v0.78.0)
|

### Upgrade

```bash
vp upgrade
```

If `vp upgrade` must download Node.js and `VP_NODE_DIST_MIRROR` points
to a mirror that rejects requests without a `User-Agent` header, such as
`mirrors.aliyun.com`, unset it or point it to another mirror for this
upgrade. The installed `vp` downloads Node.js and does not send the
header yet.

### New Contributors

@alexicum, @evan-lc, @CheHyeonYeong

**Full Changelog**:
v1.5.1...v1.6.0

---

For a stable release, complete the `HomebrewFormula/vp.rb` update after
publication by merging the generated `release/homebrew-v1.6.0` PR.

Merging this PR will trigger the release workflow.

---------

Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com>
Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@BrewTestBot BrewTestBot mentioned this pull request Nov 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees

No one assigned

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wan9chi @fengmk2