vsg::CoordinateFrame, vsg::CameraSampler & long double support. - #1347
Merged
Conversation
… to CameraSampler.
Contributor
|
This PR (or the adjustments to the examples that it mandated) seem to have broken support for existing serialised camera animations. The camera path files I used to feed to the vsgShadow example for performance testing don't do anything anymore. |
Collaborator
Author
|
My initial thought was I probably chose not to implement backwards compatibility due to the extra complexity required and likehood that the backwards compatibility wouldn't be widely required. But perhaps I need to revisit this if it's more widely used. What is the status of this issue now that I've merged your PR for the ViewMatrix serialization? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.