Skip to content

T9164: accept NOS-/VD- Jira keys in task-id check; pin NOS in coderabbit - #46

Merged
andamasov merged 1 commit into
rollingfrom
nos-task-id
Aug 5, 2026
Merged

andamasov merged 1 commit into
rollingfrom
nos-task-id

Conversation

@andamasov

Copy link
Copy Markdown
Member

Fleet replication of the adversarially-reviewed canary vyos/vyos-1x#5379 for the VD→NOS Jira project rename (T9164). .github/mergify.yml — the invalid-task-id rule's two regexes and its description now accept T<digits>:, NOS-<digits>: and legacy VD-<digits>: keys; the rule name is byte-identical, so this stays additive rather than an extends: override. .coderabbit.yaml — knowledge_base.jira.project_keys pins NOS ahead of the retained legacy VD. Byte-identical template application — skip-adversarial per the documented escape hatch (2 findings were found and fixed on the canary; regexes ship tightened: ASCII digits + literal-space separators).

Phase 0 (local CodeRabbit CLI, --base origin/rolling): clean — 0 findings.

Advances: IS-640

🤖 Generated by robots

VD tracker project renamed to NOS (2026-07) - PR titles and commit headlines
using the new NOS- key must stop being flagged invalid-task-id; legacy VD-
keys stay accepted, and CodeRabbit now resolves NOS alongside VD. Fleet
replication of canary vyos/vyos-1x#5379, whose adversarial review tightened
the regexes to ASCII [0-9] + literal-space separators.

🤖 Generated by [robots](https://vyos.io)
@andamasov andamasov added the skip-adversarial adversarial gate escape hatch label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 79503388-4d0e-4fec-8f2c-70114bb77e17

📥 Commits

Reviewing files that changed from the base of the PR and between d97e305 and 29cec7f.

📒 Files selected for processing (2)
  • .coderabbit.yaml
  • .github/mergify.yml

📝 Walkthrough

Summary by CodeRabbit

  • Improvements
    • Updated task reference validation to support current and legacy task formats.
    • Added recognition for the renamed project identifier.
    • Improved guidance for accepted task formats in automated workflows.

Walkthrough

The repository now includes the NOS Jira project key. Mergify task validation accepts T<digits>, NOS-<digits>, and VD-<digits> formats with a required following space.

Changes

Task ID configuration

Layer / File(s) Summary
Jira project registration
.coderabbit.yaml:29
Adds NOS to the CodeRabbit Jira project_keys list.
Mergify task validation
.github/mergify.yml:28-44
Updates rule descriptions and regular expressions to accept T<digits>, NOS-<digits>, and VD-<digits> with an explicit space after the identifier.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch nos-task-id

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the rolling label Aug 4, 2026
@mergify

mergify Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • check-success = Configuration changed

@andamasov
andamasov marked this pull request as ready for review August 5, 2026 09:25

@vyos-bot vyos-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by vyos-bot on operator instruction (bot-approve flow, IS-619) — NOS fleet sweep batch (T9164).

@andamasov
andamasov merged commit 37b708d into rolling Aug 5, 2026
8 of 9 checks passed
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed This PR has been mirrored successfully and removed mirror-initiated This PR initiated for mirror sync workflow labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mirror-completed This PR has been mirrored successfully rolling skip-adversarial adversarial gate escape hatch

Development

Successfully merging this pull request may close these issues.

1 participant