Skip to content

Add substrate-parachain-PoS-template - #1370

Merged
Noc2 merged 13 commits into
masterfrom
unknown repository
Dec 30, 2022
Merged

Noc2 merged 13 commits into
masterfrom
unknown repository

Conversation

@octavei

@octavei octavei commented Dec 15, 2022 •

Copy link
Copy Markdown
Contributor

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • A BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (aUSD/USDT) address for the payment of the milestones is provided in the application.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@CLAassistant

CLAassistant commented Dec 15, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Noc2 Noc2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

@Noc2 Noc2 self-assigned this Dec 16, 2022
@Noc2 Noc2 added changes requested The team needs to clarify a few things first. details missing Not enough technical details. labels Dec 16, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for submitting a grant application.

We've assessed your submission and have found that it requires a higher level of technical detail in order to be considered for review. We encourage you to expand on it by providing a more precise specification/technical details. The section on project details in the application template is a good reference as to what type of information we expect applicants to provide, and these category-specific requirements contain more precise guidelines depending on what type of software you're building.

An area of the application that we often find to be insufficiently elaborated are the milestone deliverables. At a minimum, please indicate what languages/technologies you will be using to implement each deliverable, and provide a technical summary of its expected functionality. Note that deliverables should be tangible, reusable by other teams and in most cases not already present in the ecosystem. If they are, you will need to provide a comparison to existing implementations and explain why it makes sense to fund your approach. Also see our FAQ for a breakdown of what we fund and what we don't.

Let us know as soon as you're done with your changes, and we'll give your application another look!

@octavei

octavei commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

thank you so much for your suggestion. I have made corresponding modifications to the submitted pr.

@octavei

octavei commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for submitting a grant application. We've assessed your submission and have found that it requires a higher level of technical detail in order to be considered for review. We encourage you to expand on it by providing a more precise specification/technical details. The section on project details in the application template is a good reference as to what type of information we expect applicants to provide, and these category-specific requirements contain more precise guidelines depending on what type of software you're building. An area of the application that we often find to be insufficiently elaborated are the milestone deliverables. At a minimum, please indicate what languages/technologies you will be using to implement each deliverable, and provide a technical summary of its expected functionality. Note that deliverables should be tangible, reusable by other teams and in most cases not already present in the ecosystem. If they are, you will need to provide a comparison to existing implementations and explain why it makes sense to fund your approach. Also see our FAQ for a breakdown of what we fund and what we don't. Let us know as soon as you're done with your changes, and we'll give your application another look!

The focus of this grant is not on technical breakthroughs, but on the convenience of the community and developers. Let them no longer do repetitive work because there is no unified PoS template.

@octavei

octavei commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

thank you so much for your suggestion. I have made corresponding modifications to the submitted pr.

I have added the technical details. If there are other details that I need to add, I hope you can point them out and I will finish them as soon as possible. We think it is really important to have such a PoS development template, which will speed up the development of other teams without having to do repetitive things. Of course, in this template, you can also use PoA if you have requirements for random block generation.

@octavei

octavei commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

thank you so much for your suggestion. I have made corresponding modifications to the submitted pr.

I have added the technical details. If there are other details that I need to add, I hope you can point them out and I will finish them as soon as possible. We think it is really important to have such a PoS development template, which will speed up the development of other teams without having to do repetitive things. Of course, in this template, you can also use PoA if you have requirements for random block generation.

At present, many parachain projects have not been able to use Substrate's Staking, which we think is a pity. This is not good for their token economic model, and also increases the economic burden on the project side, especially for small teams. On the other hand, Polkadot's technology needs to be unified, instead of each project party having its own Staking. They need such templates to develop.

@octavei
octavei requested a review from Noc2 December 17, 2022 06:15
@octavei

octavei commented Dec 22, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

Thanks for your interest in our grants program. But you are currently adding seven files to our repository rather than a single application. Could you update this PR?

thank you so much for your suggestion. I have made corresponding modifications to the submitted pr.

I have added the technical details. If there are other details that I need to add, I hope you can point them out and I will finish them as soon as possible. We think it is really important to have such a PoS development template, which will speed up the development of other teams without having to do repetitive things. Of course, in this template, you can also use PoA if you have requirements for random block generation.

At present, many parachain projects have not been able to use Substrate's Staking, which we think is a pity. This is not good for their token economic model, and also increases the economic burden on the project side, especially for small teams. On the other hand, Polkadot's technology needs to be unified, instead of each project party having its own Staking. They need such templates to develop.

Dear @Noc2 , Is there anything else to add here? If so, please let me know. Merry Christmas

@Noc2 Noc2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, and sorry for the late reply. In general, the application looks much better now. I just have a few more questions/comments:

  • What exactly do you mean with “try-runtime”? If this already exists, could you link to it?
  • Could you specifically list all the “staking-related substrate native modules”?
  • What do you exactly mean by collectors? Or did you mean Collators here? In general, some of your text is a little bit hard to understand. I assume the main reason is that English isn’t your native language, which obviously isn’t a problem.

@octavei

octavei commented Dec 27, 2022 •

Copy link
Copy Markdown
Contributor Author

English is really not my native language, I'm trying to improve it.

try-runtime means that I want to add code related to data migration testing in the client, just like https://github.com/substrate-developer-hub/substrate-parachain-template/blob/main/node/src/command.rs#L234, which is not currently in my template. collectors really means Collators.

@octavei

octavei commented Dec 27, 2022

Copy link
Copy Markdown
Contributor Author
  • staking-related substrate native modules

staking-related substrate native modules means adding Staking, ElectionProviderMultiPhase, VoterList and NominationPools modules to this pos template, and the code has been completed here.

@octavei

octavei commented Dec 27, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the update, and sorry for the late reply. In general, the application looks much better now. I just have a few more questions/comments:

  • What exactly do you mean with “try-runtime”? If this already exists, could you link to it?
  • Could you specifically list all the “staking-related substrate native modules”?
  • What do you exactly mean by collectors? Or did you mean Collators here? In general, some of your text is a little bit hard to understand. I assume the main reason is that English isn’t your native language, which obviously isn’t a problem.

We want to make a general POS parachain development template, just like the POA development template. This is very valuable. It will save developers time if they want to develop a parachain with PoS.

@octavei

octavei commented Dec 27, 2022

Copy link
Copy Markdown
Contributor Author

I have made changes to the application, maybe the previous information was not described accurately enough. Thank you so much for your kind and valuable reply.

@Noc2 Noc2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I have one last comment: could you also add unit tests and not only "manual test"?

@Noc2 Noc2 removed the details missing Not enough technical details. label Dec 28, 2022
@octavei

octavei commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the update. I have one last comment: could you also add unit tests and not only "manual test"?

Both unit tests and manual tests are provided.

@octavei

octavei commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the update. I have one last comment: could you also add unit tests and not only "manual test"?

We will provide unit testing and benchmarking for the Collators pallet.

@Noc2

Noc2 commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

Could you add this to the milestone and the specification of it?

@octavei

octavei commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

Could you add this to the milestone and the specification of it?

I just added it.

@octavei

octavei commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

Could you add this to the milestone and the specification of it?

Thanks for replying so quickly. If there is anything else to add, I will do it as soon as possible.

@Noc2 Noc2 added referral program The application contains a filled out referral form ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Dec 30, 2022

@Noc2 Noc2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'm happy to go ahead with it and mark the application as ready for review.

@Noc2
Noc2 merged commit 69e3fdb into w3f:master Dec 30, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at grantsPR@web3.foundation and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@octavei octavei mentioned this pull request Jan 3, 2023
7 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The project is ready to be reviewed by the committee members. referral program The application contains a filled out referral form

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants