Repository navigation
Fix Windows crash bug - #4460
Merged
Merged
Conversation
I've successfully fixed the nil pointer dereference bug in the Wails v3 system tray functionality on Windows. Here's what I addressed: **Root Cause**: The bug occurred in `systemtray_windows.go:80` where `*trayBounds = PhysicalToDipRect(*trayBounds)` was dereferencing a potentially nil pointer without checking. **Fixes Applied**: 1. **`positionWindow` method (lines 80-82)**: Added nil check for `trayBounds` before dereferencing 2. **`bounds` method (lines 121-123, 129-131)**: Added checks for uninitialized `hwnd` and nil return from `GetSystrayBounds` 3. **`iconIsInTrayBounds` method (lines 147-149, 155-157, 160-162)**: Added similar protective checks and taskbar position validation 4. **`getScreen` method (lines 173-175)**: Added `hwnd` initialization check 5. **`openMenu` method (lines 45-47)**: Added nil check for `trayBounds` **Key Improvements**: - Added proper initialization checks for `s.hwnd == 0` - Added nil pointer checks for all Windows API return values - Ensured graceful error handling instead of panics - Maintained existing functionality while preventing race conditions The fix addresses the race condition where system tray operations could be called before the tray was fully initialized, preventing the nil pointer dereference panic described in issue #4456.
Contributor
|
Warning Rate limit exceeded@dosubot[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 29 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughDefensive error handling has been added to several methods in the Windows system tray implementation. The updates introduce explicit nil checks and error returns for uninitialized or unavailable system tray bounds, handles, and related resources, aiming to prevent nil pointer dereferences and clarify error reporting in internal logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
dosubot
Bot
added
the
size:S
Contributor
|
dosubot
Bot
added
Bug
Deploying wails with
|
| Latest commit: |
d303fa7
|
| Status: | ⚡️ Build in progress... |
github-actions
Bot
added
the
Documentation
dosubot
Bot
added
size:M
|
6 of 15 tasks
13 tasks done
Grantmartin2002
pushed a commit
to Grantmartin2002/wails
that referenced
this pull request
Apr 29, 2026
* ## Summary I've successfully fixed the nil pointer dereference bug in the Wails v3 system tray functionality on Windows. Here's what I addressed: **Root Cause**: The bug occurred in `systemtray_windows.go:80` where `*trayBounds = PhysicalToDipRect(*trayBounds)` was dereferencing a potentially nil pointer without checking. **Fixes Applied**: 1. **`positionWindow` method (lines 80-82)**: Added nil check for `trayBounds` before dereferencing 2. **`bounds` method (lines 121-123, 129-131)**: Added checks for uninitialized `hwnd` and nil return from `GetSystrayBounds` 3. **`iconIsInTrayBounds` method (lines 147-149, 155-157, 160-162)**: Added similar protective checks and taskbar position validation 4. **`getScreen` method (lines 173-175)**: Added `hwnd` initialization check 5. **`openMenu` method (lines 45-47)**: Added nil check for `trayBounds` **Key Improvements**: - Added proper initialization checks for `s.hwnd == 0` - Added nil pointer checks for all Windows API return values - Ensured graceful error handling instead of panics - Maintained existing functionality while preventing race conditions The fix addresses the race condition where system tray operations could be called before the tray was fully initialized, preventing the nil pointer dereference panic described in issue wailsapp#4456. * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt at fixing the nil dereference bug
closes #4456
Summary by CodeRabbit