Repository navigation
fix(runtime): wrap string errors in Error objects in binding callbacks - #5250
Closed
leaanthony wants to merge 1 commit into
Closed
leaanthony wants to merge 1 commit into
leaanthony wants to merge 1 commit into
Conversation
When a Go binding returns an error, the JS runtime's Callback function rejected the promise with the raw string from Go instead of wrapping it in an Error object. This broke error handling in libraries like TanStack Query that expect rejected values to be Error instances. Now wraps string errors in new Error() while passing non-string errors through unchanged. Fixes #4379
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4379
When a Go binding returns an error, the JS runtime's
Callbackfunction rejected the promise with the raw string from Go instead of wrapping it in anErrorobject. This broke error handling in libraries like TanStack Query that expect rejected values to beErrorinstances (e.g.,error.messagewas undefined).Changes
calls.js:Callback(), changedreject(message.error)toreject(typeof message.error === 'string' ? new Error(message.error) : message.error)runtime_debug_desktop.js,runtime_prod_desktop.js)Testing
v2/test/4379/binding_error_test.jsverifying string errors are wrapped in Error, object errors pass through, and success cases still work