[archy-rock3t-cloud]

Description

The JS runtime ships Window.SetFullscreenButtonEnabled (method 28) but processWindowMethod has no case for it, so the call always rejects with Unknown method 28.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

New unit test that fails before the fix and passes after; package suite green.

• Windows
• macOS
• Linux

Test Configuration

macOS 26.5.2 (darwin/arm64), go1.26.4, Wails CLI v3.0.0-dev (source checkout)

Checklist:

• My code follows the general coding style of this project
• I have performed a self-review of my own code
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Summary by CodeRabbit

• New Features

  • Added support for enabling or disabling the window’s fullscreen button.

• Bug Fixes

  • Invalid or missing settings are now handled safely without changing the fullscreen button state.

• Tests

  • Added coverage for enabling, disabling, and validating fullscreen button settings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cb3a3dd1-b2d7-4293-94e6-7b81dff882e5

📥 Commits

Reviewing files that changed from the base of the PR and between 495a094 and 663cfc1.

📒 Files selected for processing (2)

• v3/pkg/application/messageprocessor_window.go
• v3/pkg/application/messageprocessor_window_internal_test.go

---

Walkthrough

The window message processor now handles WindowSetFullscreenButtonEnabled. It validates the boolean argument, updates the fullscreen button state, returns an empty result, and includes tests for valid and invalid requests.

Changes

Fullscreen button handling

Layer / File(s)	Summary
Message processing and validation v3/pkg/application/messageprocessor_window.go, v3/pkg/application/messageprocessor_window_internal_test.go	WindowSetFullscreenButtonEnabled validates its argument, maps it to ButtonEnabled or ButtonDisabled, updates the window state, and returns an empty result. Tests cover dispatch, state changes, unit results, and invalid or missing arguments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 663cf

This localized fix enables the fullscreen-button runtime call and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• wailsapp/wails#5224: Introduces fullscreen button state functionality used by this message path.
• wailsapp/wails#5319: Adds runtime fullscreen-button state handling invoked by this path.

Suggested labels: reviewed ✅

Poem

A rabbit taps the window bright,
“Enable buttons!” says the light.
False turns the fullscreen glow away,
Tests keep both states in play.
Hop, hop—clean messages all the way!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the fix for the missing SetFullscreenButtonEnabled runtime call handling.
Description check	✅ Passed	The description explains the bug, identifies the fix, documents testing and configuration, and marks the relevant checklists.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

Submitted through the wrong connector identity during automated validation; superseded by taliesin-ai review.

[leaanthony]

Nice catch! Thank you 🙏