Repository navigation
Conversation
|
No actionable comments were generated in the recent review. WalkthroughWindows popup menus now use caller-configured alignment. Menus use top-left alignment by default. System tray menus enable bottom-edge alignment and retain a monitor-edge adjustment near the right edge. ChangesWindows popup positioning
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk:
|
|
Thanks for picking this up, @DangTAnh. As the author of #6272, I confirm the change matches the fix proposed there: window context menus open at the cursor (no The branch now has a merge conflict with |
Description
Fixes #6272.
Windows webview context menus call
NewPopupMenuandShowAtCursor, whose sharedWin32Menu.ShowAtimplementation hard-codes bottom alignment. This opens context menus above the cursor and can cover the clicked item.Use native top-left placement for context menus. An unexported
showAboveCursorflag preserves tray menus' previous bottom alignment and right-edge clamp. Keep the current upstream menu ownership, rebuilding, concurrency and cursor handling intact.Type of change
How Has This Been Tested?
Refreshed branch, Go 1.26.10, from
v3/:go build ./pkg/application— pass.go test ./pkg/application -run Menu -count=1— pass.go test ./pkg/application -count=1— pass.go vet ./pkg/application— the same nine upstreamunsafe.Pointerwarnings, with no new findings.Historical native verification before this refresh used
examples/contextmenusat cursor (1280,406): the fixed menu bounds were (1280,406)-(1824,487), while the original bounds were (1280,324)-(1824,405). This is historical evidence; no new GUI or tray visual run was performed for this refresh. The alignment change calls the blocking native menu API; no new test harness was introduced.The required
coderabbit --plaincommand was attempted but the CLI is not installed; independent agent review was performed.Test Configuration
Windows/amd64, Go 1.26.10.
wails doctorwas not run.Checklist:
v3/UNRELEASED_CHANGELOG.mdAI-assisted contribution using OpenAI Codex (GPT-6).
Summary by CodeRabbit