Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposes
Mac.WebviewPreferences.InactiveSchedulingPolicy, a per-window, opt-in option that maps one to one toWKPreferences.inactiveSchedulingPolicyon macOS 14+.On macOS 14+ the WebContent process of a window that has never been shown is suspended by default, so a page in a
Hidden: truewindow that waits on a timer before showing itself can hang. Applications cannot fix this themselves, because WebKit latches the policy when the page is created and Wails creates theWKWebViewinternally.This overlaps with #5920, which uses the same WebKit preference and also covers Windows. The proposal explains the differences: named values instead of a boolean whose
falseis not the default, macOS only so it does not depend on the Windows dead-zone trade-off, and coverage of the CGO-free macOS backend. It also adds findings that apply either way, such as the behaviour being gated on the linked SDK.The reference implementation is on
darwin-inactive-policy. This PR contains only the proposal.Type of change