Fix IE11 in minified version & adopt ES6 in source - #5
Merged
Merged
Conversation
Contributor
Author
|
BTW, apologies for all of the back-and-forth on these IE11-related updates. Testing the first PR was challenging just because of IE11 access and how https://docsify.js.org/ is configured (it only displays ads on the live site, not in previews). These changes I was able to fully test, so this should be the last update. 🤞 Thanks! |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4
scriptElon page load. This bug was a result of how the<script>element reference was stored on theDocsifyCarbonobject. The fix is to not store an object reference and instead do aquerySelectorfor the script ID each time.index.js) has been converted to ES6. Previous, this file was a mash-mash of ES5 and ES6 syntax, so it was already broken in legacy browsers. Adopting ES6 syntax entirely is therefore not a breaking change and provides a better dev experience. The build command listed in theREADME.mdwill handle transpiring the ES6 source to ES5 for legacy browsers.