argocd: add redis - #171
Merged
Merged
Conversation
deer-wmde
marked this pull request as ready for review
October 17, 2024 16:30
This commit also introduces using a variable in the app-of-apps chart to specify versions of the individual helm charts we wish to apply. This should prevent requiring a new helmfile apply needing to be run to bump versions of charts. It should also prevent us needed to release a new argocd-config chart when we want to bump a released chart version
rosalieper
reviewed
Nov 8, 2024
| clusterUrl: https://kubernetes.default.svc | ||
| environment: production | ||
|
|
||
| chartVersions: |
rosalieper
approved these changes
Nov 8, 2024
deer-wmde
commented
Nov 12, 2024
| helm: | ||
| values: | | ||
| {{ toYaml .Values | indent 8 }} | ||
| valueFiles: |
Contributor
Author
There was a problem hiding this comment.
does this work? I vaguely remember that only values or valuesFiles will get used, but I could be wrong
Contributor
There was a problem hiding this comment.
Unlesss I've ended up in a right muddle yes, this seems to work fine
Contributor
|
If you want to fully try this locally the easiest way to do so is to tweak helmfile.yml to use a local copy of the
|
tarrow
added a commit
that referenced
this pull request
Nov 13, 2024
AndrewKostka
approved these changes
Nov 14, 2024
dati18
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds redis to the app-of-apps application that is shipped by
argocd-configThis commit increases the version of both
argocd-configandargocd-appschartsDeploying the new
argocd-configchart using helmfile will result in redis being managed by argo becauseit will automatically use the new
argocd-appschartThis PR also introduces a new pattern of using a value rather than hardcoding the redis chart version in the
ApplicationtemplateThis is done to allow us to bump the version of the redis chart in future without new
argocd-configorargocd-appscharts. This will not be possible immediately though, we will need to introduce a source of values files direct from the deploy repo which will be done in a follow-up patch.Bug: T375195