Conversation
|
currently investigating why the |
|
seems to be related to some change in the Math extension: https://github.com/wbstack/mediawiki/pull/439/files#diff-9ed2b2e3b9657cb4a1d52bfb247b0c11d6b0cc8523911de3632c9f791a054bb2 |
| repoName: wikimedia/mediawiki-extensions-Kartographer | ||
| - name: Math | ||
| repoName: wikimedia/mediawiki-extensions-Math | ||
| repoRef: 2822d35380c87960c56111be025fd2c5817e919e |
There was a problem hiding this comment.
I read your comment and the ticket but TBH I failed to understand why we need to pin back to this version; would we be better to either add a patch or actually backport the change to the repo upstream?
There was a problem hiding this comment.
Solely to prioritize the deployment of the security fix, that cleanup can happen in a follow up PR IMO
There was a problem hiding this comment.
using up-to-date code resolved this
tarrow
left a comment
There was a problem hiding this comment.
Looks fantastic to me; I'm happy that generally "unpinning" and using master/main of everything where possible seems to be a pattern that's working. Thanks so much for the continued effort to get this over the line!
Yeah I'm also glad that resolved it, thanks for pointing me in the right direction! |
https://lists.wikimedia.org/hyperkitty/list/mediawiki-announce@lists.wikimedia.org/thread/MHGBY3I2OCL7IMUL6F6NUHEWXAZ3DWFE/
https://phabricator.wikimedia.org/T361202