Skip to content

Update mediawiki to 1.39.7 - #439

Merged
deer-wmde merged 13 commits into
mainfrom
de/1.39.7
Apr 26, 2024
Merged

deer-wmde merged 13 commits into
mainfrom
de/1.39.7

Conversation

@deer-wmde

Copy link
Copy Markdown
Contributor

@deer-wmde

Copy link
Copy Markdown
Contributor Author

currently investigating why the MediaWiki Verify CI check is failing. Comparison of the responses via docker compose:
https://phabricator.wikimedia.org/P61095 vs https://phabricator.wikimedia.org/P61096

@deer-wmde

Copy link
Copy Markdown
Contributor Author

seems to be related to some change in the Math extension: https://github.com/wbstack/mediawiki/pull/439/files#diff-9ed2b2e3b9657cb4a1d52bfb247b0c11d6b0cc8523911de3632c9f791a054bb2

{
  "id": "a4c957e6698c95e98f42432a",
  "type": "ErrorException",
  "file": "/var/www/html/w/includes/Rest/Router.php",
  "line": 186,
  "message": "PHP Warning: filemtime(): stat failed for /var/www/html/w//var/www/html/w/extensions/Math/popupRestRoutes.json",
  "code": 0,
  "url": "/w/rest.php",
  "caught_by": "mwe_handler",
  "backtrace": [
    {
      "function": "handleError",
      "class": "MWExceptionHandler",
      "type": "::",
      "args": [
        "integer",
        "string",
        "string",
        "integer",
        "array"
      ]
    },
    {
      "file": "/var/www/html/w/includes/Rest/Router.php",
      "line": 186,
      "function": "filemtime",
      "args": [
        "string"
      ]
    },
    {
      "file": "/var/www/html/w/includes/Rest/Router.php",
      "line": 221,
      "function": "getRoutesFromFiles",
      "class": "MediaWiki\\Rest\\Router",
      "type": "->",
      "args": []
    },
    {
      "file": "/var/www/html/w/includes/Rest/Router.php",
      "line": 240,
      "function": "getAllRoutes",
      "class": "MediaWiki\\Rest\\Router",
      "type": "->",
      "args": []
    },
    {
      "file": "/var/www/html/w/includes/Rest/Router.php",
      "line": 363,
      "function": "getMatchers",
      "class": "MediaWiki\\Rest\\Router",
      "type": "->",
      "args": []
    },
    {
      "file": "/var/www/html/w/includes/Rest/EntryPoint.php",
      "line": 170,
      "function": "execute",
      "class": "MediaWiki\\Rest\\Router",
      "type": "->",
      "args": [
        "MediaWiki\\Rest\\RequestFromGlobals"
      ]
    },
    {
      "file": "/var/www/html/w/includes/Rest/EntryPoint.php",
      "line": 135,
      "function": "execute",
      "class": "MediaWiki\\Rest\\EntryPoint",
      "type": "->",
      "args": []
    },
    {
      "file": "/var/www/html/w/rest.php",
      "line": 35,
      "function": "main",
      "class": "MediaWiki\\Rest\\EntryPoint",
      "type": "::",
      "args": []
    }
  ],
  "@type": "type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent",
  "severity": "error",
  "serviceContext": {
    "service": "WBaaS MediaWiki",
    "version": "1.0.0"
  }
}

Comment thread dist/extensions/Math/extension.json
Comment thread wikiman.yaml Outdated
repoName: wikimedia/mediawiki-extensions-Kartographer
- name: Math
repoName: wikimedia/mediawiki-extensions-Math
repoRef: 2822d35380c87960c56111be025fd2c5817e919e

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read your comment and the ticket but TBH I failed to understand why we need to pin back to this version; would we be better to either add a patch or actually backport the change to the repo upstream?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solely to prioritize the deployment of the security fix, that cleanup can happen in a follow up PR IMO

@deer-wmde deer-wmde Apr 24, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using up-to-date code resolved this

Comment thread wikiman.yaml Outdated

@tarrow tarrow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic to me; I'm happy that generally "unpinning" and using master/main of everything where possible seems to be a pattern that's working. Thanks so much for the continued effort to get this over the line!

@deer-wmde

Copy link
Copy Markdown
Contributor Author

Looks fantastic to me; I'm happy that generally "unpinning" and using master/main of everything where possible seems to be a pattern that's working. Thanks so much for the continued effort to get this over the line!

Yeah I'm also glad that resolved it, thanks for pointing me in the right direction!

@deer-wmde
deer-wmde merged commit 4050003 into main Apr 26, 2024
@deer-wmde
deer-wmde deleted the de/1.39.7 branch April 26, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants