Add support for not having to pin strip-ansi #1286

Activity

1. TheLarkInn

   added

   type: ci

   severity: 4 (inconvenient)

   status: approved

   on Jan 19, 2018
2. alexander-akait commented on Jan 19, 2018

   

   alexander-akait

   on Jan 19, 2018

   Member

   More actions

   @TheLarkInn need patch release after merge, otherwise babel would be a more rational solution
3. lydell commented on Jan 19, 2018

   

   lydell

   on Jan 19, 2018

   More actions

   See #1279 for a potential solution of running node_modules through Babel.
4. TheLarkInn commented on Jan 19, 2018

   

   TheLarkInn

   on Jan 19, 2018 via email

   MemberAuthor

   More actions

   I have an issue to add this but for now since it's breaking current implementations I'd like to see pin and patched.

   …

   On Fri, Jan 19, 2018, 12:24 PM Simon Lydell ***@***.***> wrote: See #1279 <#1279> for a potential solution of running node_modules through Babel. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1286 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADQBMBgPv6ouyiFfPv2mPR7TKqMdBQLTks5tMPnhgaJpZM4Rk-d2> .
5. wayofthefuture commented on Jan 21, 2018

   

   wayofthefuture

   on Jan 21, 2018

   More actions

   Broke the entire build
6. kaiyoma commented on Jan 23, 2018

   

   kaiyoma

   on Jan 23, 2018

   More actions

   This is causing issues with our project too. If I try to upgrade to the latest version, I start getting yarn errors:

   error "nyc#string-width#strip-ansi" is wrong version: expected "4.0.0", got "3.0.1"
   warning "nyc#string-width#strip-ansi#ansi-regex@^2.0.0" could be deduped from "2.1.1" to "ansi-regex@2.1.1"
   error "nyc#strip-ansi#ansi-regex" is wrong version: expected "3.0.0", got "2.1.1"
   error Found 2 errors.
   

   We're currently on version 2.10.0 and would like to upgrade as the dev server is broken in IE11 in this version.
7. robvree commented on Feb 2, 2018

   

   robvree

   on Feb 2, 2018

   More actions

   This is also breaking our dev build in IE11. Running node_modules through babel is not a solution. Everything in node_modules should already be transpiled.
8. robvree commented on Feb 2, 2018

   

   robvree

   on Feb 2, 2018

   More actions

   Update: Updating from 2.11.0 to 2.11.1 (which uses v3 of strip-ansi) and moving my polyfill for es6-object-assign above the first import in my entry point (not sure if this is related) has fixed my IE11 build.

   // polyFills for IE11 that need to run before the imports
   require("es6-object-assign").polyfill();
   
   // react-hot-loader must come before importing React
   import "react-hot-loader";
   import * as React from "react";
   import { render } from "react-dom";
   import App from "./staffhub/sh-application/components/App";
   import DateUtils from "sh-application/utility/DateUtils";
   import StringsStore from "sh-strings/store";
   import { loadTheme } from "@uifabric/styling";
   import { preinitApplication } from "sh-application";
   import { initializeIcons } from "@uifabric/icons";
   
   // polyFills for IE11
   require("es6-promise").polyfill();
   require("string.prototype.startswith");
   require("element-closest");
   require("ie-array-find-polyfill");
   require("array.from").shim();
   require("array.prototype.findIndex").shim();
   
9. michael-ciniawsky

   added

   priority: 3 (important)

   type: chore

   and removed

   status: approved

   type: ci

   on Aug 26, 2018
10. michael-ciniawsky

    added this to the 3.2.0 milestone on Aug 26, 2018
11. alexander-akait

    modified the milestones: 3.2.0, 4.0.0 on Feb 21, 2019
12. alexander-akait commented on May 12, 2020

    

    alexander-akait

    on May 12, 2020

    Member

    More actions

    Done for v4
13. alexander-akait

    closed this as completedon May 12, 2020