Repository navigation
Conversation
The test would falsely report that "sendUpdate" worked 0 times. The bug has probably been surfaced by ada6442 (#39), which reordered the `<script>` tags, which made `setUpdateListener()` run before `anotherWebxdcUpdateListener` was set. This commit makes it not matter which order the scripts run in, by introducing a "wrapper" around `setUpdateListener`. We also had to move that piece of code in `unload.js` because otherwise the listener would try to update the elements before they have been inserted in the document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test would falsely report that "sendUpdate" worked 0 times.
The bug has probably been surfaced by
ada6442
(#39),
which reordered the
<script>tags, which madesetUpdateListener()run before
anotherWebxdcUpdateListenerwas set.This commit makes it not matter which order the scripts run in,
by introducing a "wrapper" around
setUpdateListener.We also had to move that piece of code in
unload.jsbecause otherwise the listener would try to update the elements
before they have been inserted in the document.