Repository navigation
fix: AbiError.decode resolves overloads by selector - #602
Merged
Merged
Conversation
AbiError.decode(abi, name, data) decoded with whichever overload fromAbi picked by name, so data for another overload of the same error decoded as undefined or with the wrong parameters. It now resolves the overload from the selector in data, like AbiFunction.decodeData, and its return type includes the overloads' inputs. Amp-Thread-ID: https://ampcode.com/threads/T-01a1bc8e-e129-76ad-b0c4-3188e7e62ad9 Co-authored-by: jxom <jake@tempo.xyz>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Published pnpm add ox@pr-602
pnpm add ox@0.0.0-pr-602-9a7d9cd |
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #598 / #599.
AbiError.decode(abi, name, data)ignored overloads: it decodeddatawith whichever overloadfromAbipicked by name. Witherror Example()+error Example(uint256), decodingExample(uint256)data by name returnedundefined; with several non-zero overloads it decoded with the wrong parameters.AbiError.decodenow resolves the overload from the selector indata, likeAbiFunction.decodeData.decode.ReturnTypedistributes over the error and its overloads (bigint | string | undefinedforExample()/Example(uint256)/Example(string)).