Skip to content

fix: reject line breaks in Siwe.createMessage requestId - #642

Merged
jxom merged 1 commit into
mainfrom
fix/siwe-request-id-line-breaks
Nov 11, 2026
Merged

jxom merged 1 commit into
mainfrom
fix/siwe-request-id-line-breaks

Conversation

@jxom

@jxom jxom commented Nov 11, 2026

Copy link
Copy Markdown
Member

Siwe.createMessage now throws InvalidMessageFieldError for a requestId that contains a line break.

@vercel

vercel Bot commented Nov 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Error Error Nov 11, 2026 4:02am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T04:03:33.413105Z 4f2ae02 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jxom
jxom merged commit f620088 into main Nov 11, 2026
14 of 15 checks passed
@jxom
jxom deleted the fix/siwe-request-id-line-breaks branch November 11, 2026 04:25
@github-actions github-actions Bot mentioned this pull request Nov 11, 2026

This branch had an error being deployed

1 failed deployment
Preview — 4f2ae02c Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants