Skip to content

fix(0.x): derive chain ID from v in TxEnvelopeLegacy presign hash - #661

Merged
jxom merged 1 commit into
0.xfrom
fix/tx-envelope-legacy-presign-chain-id-0.x
Nov 11, 2026
Merged

jxom merged 1 commit into
0.xfrom
fix/tx-envelope-legacy-presign-chain-id-0.x

Conversation

@jxom

@jxom jxom commented Nov 11, 2026

Copy link
Copy Markdown
Member

0.x port of #660.

TxEnvelopeLegacy.getSignPayload and TxEnvelopeLegacy.hash with presign now derive the chain ID from an EIP-155 v when the envelope has no chainId.

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Ready Ready Preview Nov 11, 2026 4:07am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T04:05:39.089665Z 1b1ed4f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Published ox@0.0.0-pr-661-1b1ed4f under the pr-661 dist-tag, which follows this pull request until it closes.

pnpm add ox@pr-661
pnpm add ox@0.0.0-pr-661-1b1ed4f

@jxom
jxom merged commit 1f55fd7 into 0.x Nov 11, 2026
14 checks passed
@jxom
jxom deleted the fix/tx-envelope-legacy-presign-chain-id-0.x branch November 11, 2026 04:59
@github-actions github-actions Bot mentioned this pull request Nov 11, 2026

This branch was successfully deployed

1 active deployment
Preview — 1b1ed4f5 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants