fix: URLs in error meta-messages#4564
Merged
Merged
Conversation
Previously, errors raised by HttpRequestError, WebSocketRequestError, RpcRequestError, and TimeoutError formatted the request URL verbatim in their meta-messages — which leaked basic-auth credentials when an RPC URL of the form 'https://user:pass@host' was used. 'getUrl' (the single chokepoint shared by every URL-bearing error formatter in src/errors/request.ts) is now a sanitizer: it parses the URL and clears 'username'/'password' before returning, falling back to the raw input on parse failure. Amp-Thread-ID: https://ampcode.com/threads/T-019de09d-2011-716e-a2cc-bf98f248520d
|
@jxom is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: cda1ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jxom
changed the title
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.