Repository navigation
feat(tempo): decode precompile errors with access key details and hints - #5228
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fc82df9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e67ca0fe49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3911d08efc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fdfe01fd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Skip Solidity `Error` and `Panic` reverts - Detect fee payment failures from missing revert data - Replay reverted receipts to recover revert data - Keep keychain errors about another key off the signer - Format timestamps beyond the `Date` range as seconds - Wrap Earn deployment writes
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21e95d2ffd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Load `resolveError` with a dynamic import on failure - Add `Errors.ExecutionErrorType` to wrapped read action `ErrorType` unions - Fall back to the base error when revert data has no arguments - Read the fee balance of a local `feePayer` and skip external fee payers
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 967d70043d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…out stubs - Skip `*Error` exports and `errorResolvers` in `DecorateNamespace` - Move the `AccountKeychain` fallback into `errorResolvers` - Encode contract call data before replaying reverted receipts - Unexport `Resolver` - Replace the fake transport tests with real reverts and direct resolver calls
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc82df9c7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| functionName: parameters.functionName, | ||
| }) | ||
| : undefined) | ||
| if (!reverted || !to || !data) return undefined |
There was a problem hiding this comment.
When a calls-based sync action such as earn.depositSync or zone.depositSync is submitted with explicit gas and its receipt reverts, the wrapper reaches this branch with parameters.calls but no top-level to, data, address, or ABI, so replay returns undefined and the action still throws TransactionReceiptRevertedError instead of the advertised Tempo error. The fresh evidence after the prior replay fix is that the newly wrapped batch actions pass only a calls array; recover the serialized batch or otherwise replay its calls before giving up.
Useful? React with 👍 / 👎.
| WaitForPrivateRedeemTimeoutError, | ||
| type WaitForPrivateRedeemTimeoutErrorType, | ||
| } from '../errors.js' | ||
| import { withExecutionError } from '../internal/errors.js' |
There was a problem hiding this comment.
The remaining direct write in configureExitSafePolicy still calls writeContractSync without withExecutionError, so an access-key validation failure or core registry error from createCompoundPolicy escapes as a generic contract/receipt error while the surrounding policy and token writes produce typed Tempo errors. The fresh evidence after the omitted-write fix is that this is still the sole direct write call under src/tempo/actions; wrap it and include Errors.ExecutionErrorType in this action's error union.
Useful? React with 👍 / 👎.
Tempo actions now throw typed
TempoExecutionErrorsubclasses, defined in each action module, with decoded arguments, onchain details fetched by multicall, and resolution hints. Precompile errors previously surfaced as undecoded selectors.