Repository navigation
fix: guard consumed nonce 0 in nonceManager stale-source check - #5244
Merged
Merged
Conversation
|
@erkancamli is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 58f26de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createNonceManagerremembers the last nonce it handed out, so that a source which has not caught up yet (eth_getTransactionCountatpendingbefore the previous transaction is broadcast or seen by the node) does not get the same nonce again:A missing entry defaults to
0and the guard is> 0, so a consumed nonce of0looks the same as "nothing consumed yet". For an account with no transactions, the nextconsume()against a source that still says0hands out0again. Every other account getsn + 1.Repro:
With
get: () => 5the same calls return5,6.The existing
prepareTransactionRequest"behavior: nonce manager" test shows the flow: prepare twice, then three in parallel, giving953to957for the fork account. The same steps against a local anvil for an account at nonce0give[0, 0, 0, 1, 2]onmainand[0, 1, 2, 3, 4]with this change. With a transport whose pending count lags, three sequentialsendTransactioncalls from a fresh account broadcast nonces[0, 0, 0](the same mock at count5gives[5, 6, 7]).This PR compares against
undefinedinstead of0, which is the change v3 already has inNonceManager(87b581c).Tests:
src/utils/nonceManager.test.tsadds a stale source case that fails onmain(expected +0 to be 1) and passes with this change. The rest of the file passes on both (run against a local anvil). A changeset is included.