Repository navigation
fix: bound CCIP-Read gateway fetches - #5364
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b13377c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2904f4083b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Published pnpm add viem@pr-5364
pnpm add viem@0.0.0-pr-5364-b13377c |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a753e1cb02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6914081de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Supersedes #5351 by @mortezashojaei, keeping its gateway hardening and addressing review feedback.
Summary
CCIP-Read gateway URLs are chosen by the contract, so each fetch now gets the same limits as the HTTP transport, and one lookup's fan-out is capped.
timeout(default 10s) and reads at most 10 MiB.data:URLs, which used to work, are now refused too, and the changeset says so.x-batch-gateway:truebatches. Requests over the budget come back as batch failures, so the response list keeps its length.Changes from #5351:
callruns withccipRead: falseand a nestedOffchainLookuprevert returns tooffchainLookupwithdepth + 1and the same budget. This replaces the module-levelWeakMapkeyed on clonedrequestOptions, which also changed the callback's multicall batch key.anySignalandreadResponseBodymoved tosrc/utils/internal/http.tsand are shared by the HTTP transport and CCIP.Test plan
src/utils/ccip.test.ts,src/utils/ens,src/actions/ens,src/actions/public/call.test.tsagainst Anvil: 303 passedpnpm check:types, Biome