Repository navigation
fix: estimateGas and sendTransaction failing on Anvil 1.8.5 and later - #5378
Merged
Merged
Conversation
|
@mmv08 is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 29f7cc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ater The execution-apis spec has `eth_fillTransaction` return `gasPrice` on EIP-1559 transactions, set equal to `maxFeePerGas` and marked deprecated (ethereum/execution-apis#803). It reports what the transaction would pay. It is not a fee to send back. Anvil follows the spec. `fillTransaction` kept the field, so `fillTransaction` and `prepareTransactionRequest` returned both fee fields together. Geth, reth and Anvil 1.8.5 and later reject a request that has both, with "both gasPrice and (maxFeePerGas or maxPriorityFeePerGas) specified". This broke: - `sendTransaction` with a JSON-RPC account, given a request from `prepareTransactionRequest`. - `estimateGas` with a local account, when called with `gas`, or with a `prepare` list and a block or state override. `fillTransaction` now drops `gasPrice` when the filled transaction has `maxFeePerGas`. Geth and reth leave the field out today. This change also covers them once they follow the spec. Anvil ignores `type: 0x0` and `0x1` in fill requests and returns a type-2 transaction. So on Anvil, legacy and EIP-2930 requests now take their `gasPrice` from Viem's own estimate, as they already did on Geth and reth.
mmv08
force-pushed
the
claude/heuristic-swartz-83f367
branch
from
November 2, 2026 13:47
4f17c7f to
29f7cc7
Compare
This was referenced Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution-apis spec has
eth_fillTransactionreturngasPriceon EIP-1559 transactions, set equal tomaxFeePerGasand marked deprecated (ethereum/execution-apis#803). It reports what the transaction would pay. It is not a fee to send back. Anvil follows the spec.fillTransactionkept the field, sofillTransactionandprepareTransactionRequestreturned both fee fields together. Geth, reth and Anvil 1.8.5 and later reject a request that has both, with "both gasPrice and (maxFeePerGas or maxPriorityFeePerGas) specified". This broke:sendTransactionwith a JSON-RPC account, given a request fromprepareTransactionRequest.estimateGaswith a local account, when called withgas, or with apreparelist and a block or state override.fillTransactionnow dropsgasPricewhen the filled transaction hasmaxFeePerGas. Geth and reth leave the field out today. This change also covers them once they follow the spec. Anvil ignorestype: 0x0and0x1in fill requests and returns a type-2 transaction. So on Anvil, legacy and EIP-2930 requests now take theirgasPricefrom Viem's own estimate, as they already did on Geth and reth.