Repository navigation
fix(account-abstraction): keep falsy per-operation paymasterContext over the client default - #5431
Merged
Merged
Conversation
…ver the client default `prepareUserOperation` chose between the per-operation `paymasterContext` and the bundler client default with a truthiness check, so `false`, `0`, `''`, and `null` were replaced by the default. Only `undefined` now falls back to the client default. Fixes #5418. Supersedes #5421. Co-authored-by: Saravanan <76141249+saravanan619@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWjV2LuSbn2SFpBG1hn
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f94fba2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 6, 2026
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5418. Supersedes #5421 (thanks @saravanan619, credited as co-author).
prepareUserOperationchose between the per-operationpaymasterContextand the bundler client's default with a truthiness check. Because the option is typedunknown, an explicitfalse,0,''ornullwas silently replaced by the client default, or becameundefinedif there was no default. It now checks forundefinedinstead, so the client default applies only when the per-operation option is omitted.Changes compared with #5421:
prepareUserOperation.test.tsalongside the otherpaymasterContexttests, instead of a new sibling file. It uses a function paymaster that echoes the context it receives, so it doesn't need a hand-rolled HTTP server, and it checks all values with one aggregated inline snapshot (undefined,false,0,'',null).null, which now overrides the client default as well.Attention for reviewers
test/vitest.config.tsexcludessrc/account-abstraction/**from every Vitest project, so CI does not run this test, or any account-abstraction test. That is a separate problem from this fix.main'sprepareUserOperation.ts. I could not run the full anvil + alto suite here.tsc -p src/tsconfig.jsonreports 11 errors insrc/tempo/**(userAddress). The same 11 errors appear on unmodifiedmainin this environment, which has a stalenode_modules;main's lockfile currently fails--frozen-lockfile. None of the errors are in changed files. Biome is clean.Generated by Claude Code