Repository navigation
Fix reliable message loss during UDP connection initialization - #75
Open
NikoCat233 wants to merge 1 commit into
Open
NikoCat233 wants to merge 1 commit into
NikoCat233 wants to merge 1 commit into
Conversation
Prevent retried Hello and application packets from being processed before NewConnection finishes, while allowing ACKs and disconnects. Add regression tests for both UDP listeners and fix the packet capture helper's queue synchronization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDP listeners publish new connections before
NewConnectionreturns. A retransmitted Hello can therefore be acknowledged by another thread while initialization is still running. The client then connects and sends reliable data, which can be acknowledged and discarded beforeDataReceivedis subscribed.Gate Hello and application packets until initialization completes, without acknowledging them or advancing reliable receive state. Continue processing ACKs and disconnects, and avoid acknowledging the original Hello if the connection was closed during initialization. Apply the fix to both UDP listeners without changing the wire protocol.
Add eight regression cases covering handshake retries, reliable delivery, independent connection progress, outbound ACKs, and disconnects. Also correct the packet capture helper's queue wait condition to prevent stale ACK assertions.
Validation: