Skip to content

React Native 0.85#8

Open
JP (jpdriver) wants to merge 2 commits into
mainfrom
jpdriver/main
Open

React Native 0.85#8
JP (jpdriver) wants to merge 2 commits into
mainfrom
jpdriver/main

Conversation

@jpdriver

Copy link
Copy Markdown
Collaborator

(wasn't able to push this directly to main due to the TruffleHog restriction)

see https://github.com/jpdriver/react-native-template/releases/tag/rn-0.85 for Release Notes

✌🏻

Use the localStorage polyfill for key-value storage. **Never use AsyncStorage**

```tsx
import "expo-sqlite/localStorage/install";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it preferred to use the polyfill Vs expo-sqlite/kv-store for key-value storage?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was introduced in this PR

at a guess maybe the intent is to have the same API across both native and web (where AsyncStorage isn't available)

but also to be clear, i'm not checking or re-wording anything in the .agents/skills -- these are just pulled in from expo/skills completely as-written

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! yeah makes sense! I always forget about web support LOL.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow JP this is amazing! so many good guidances in the skills and the docs/adr is fantastic! Thank you for doing this!

I'm still reviewing but will finish today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants