This repository was archived by the owner on Oct 27, 2021. It is now read-only.
Repository navigation
Conversation
Contributor
|
This looks awesome ! |
Contributor
|
Hey @kaoDev ! |
Author
|
I just opened the PR in the definitely typed repo (DefinitelyTyped/DefinitelyTyped#20575) , when it is merged I will update this branch to import the react-native-tab-view from the @types namespace |
Author
|
done, |
|
@LeoLeBras can we resole the package.json conflicts and merge? |
Contributor
|
#58 I think it would be better to add this PR to DefinitelyTyped. |
Merged
9 tasks done
Author
|
the DT pull request is now open: DefinitelyTyped/DefinitelyTyped#23114 and I realised that the declaration files were already obsolete ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
in a recent project I used this lib in a TypeScript project and want to contribute my declaration files. This PR depends on Typings for react-native-tab-view waiting for a merge in this PR: satya164/react-native-tab-view#340
Greetings
Kalle