fix: handling federation conflict when creating MLS conversation (WPB-26348) - #5239
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5239 +/- ##
===========================================
+ Coverage 53.07% 53.11% +0.03%
===========================================
Files 745 745
Lines 25858 25873 +15
Branches 4246 4249 +3
===========================================
+ Hits 13724 13742 +18
+ Misses 10794 10791 -3
Partials 1340 1340
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
sbakhtiarov
marked this pull request as ready for review
September 1, 2026 10:08
ohassine
approved these changes
Sep 1, 2026
sbakhtiarov
force-pushed
the
fix/create-group-federation-conflict
branch
from
September 7, 2026 18:36
1c69be1 to
7a2fedc
Compare
sbakhtiarov
enabled auto-merge
September 7, 2026 18:36
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26348
https://wearezeta.atlassian.net/browse/WPB-26348
What's new in this PR?
Issues
Federation conflicts during initial or retried MLS group creation were not handled consistently, and Discard could close the flow while leaving a pending local conversation.
Solutions
Route initial and retry conflicts to the existing “Conversation can’t be created” dialog. Clear pending creation state, retry local cleanup only when Kalium returns a fallback conversation ID, and close the creation flow only after discard succeeds.