Skip to content

fix: parse SSO failure errorCode - #5244

Open
MohamadJaara wants to merge 1 commit into
developfrom
mo/fix-sso-failure-error-code
Open

fix: parse SSO failure errorCode#5244
MohamadJaara wants to merge 1 commit into
developfrom
mo/fix-sso-failure-error-code

Conversation

@MohamadJaara

Copy link
Copy Markdown
Member

Goal

Fix SSO failure callbacks being mapped to an unknown error because Android and Kalium used different query parameter names.

Kalium generates the callback with errorCode in SSOUtil.generateErrorRedirect and QUERY_ERROR, while DeepLinkProcessor previously read error.

Reproduction

  1. Start an SSO login that uses redirect callbacks.
  2. Let the SSO backend return a failure callback generated from the Kalium template: wire://sso-login/failure/?errorCode=$label.
  3. Android does not find error and maps the callback to Unknown.

Change

  • Treat errorCode as the canonical Android failure parameter to match Kalium.
  • Continue accepting error as a legacy fallback for existing or external callbacks.
  • Cover the contract by passing the real compiled Kalium-generated failure redirect through Android Uri and DeepLinkProcessor.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.26%. Comparing base (e73dcbe) to head (588feff).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5244   +/-   ##
========================================
  Coverage    52.26%   52.26%           
========================================
  Files          745      745           
  Lines        25897    25900    +3     
  Branches      4235     4237    +2     
========================================
+ Hits         13534    13537    +3     
  Misses       11066    11066           
  Partials      1297     1297           
Files with missing lines Coverage Δ
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 78.08% <100.00%> (+0.45%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73dcbe...588feff. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 641 tests  +2   2 641 ✅ +2   1m 38s ⏱️ +8s
  337 suites +1       0 💤 ±0 
  337 files   +1       0 ❌ ±0 

Results for commit 588feff. ± Comparison against base commit e73dcbe.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant