fix: parse SSO failure errorCode - #5244
Open
MohamadJaara wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5244 +/- ##
========================================
Coverage 52.26% 52.26%
========================================
Files 745 745
Lines 25897 25900 +3
Branches 4235 4237 +2
========================================
+ Hits 13534 13537 +3
Misses 11066 11066
Partials 1297 1297
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix SSO failure callbacks being mapped to an unknown error because Android and Kalium used different query parameter names.
Kalium generates the callback with errorCode in SSOUtil.generateErrorRedirect and QUERY_ERROR, while DeepLinkProcessor previously read error.
Reproduction
Change