feat: add multi-ingress-support for envoy gw - #5307
Merged
Merged
Conversation
zebot
added
the
ok-to-test
jschaul
force-pushed
the
WPB-25475_Add-multi-ingress-support
branch
from
July 27, 2026 14:44
085546a to
e29c581
Compare
…S secret In manual TLS mode (tls.useCertManager: false) secret.yaml creates only the single primary wildcard secret and no cert-manager Certificate is rendered, so an additional config.domains entry produced a Gateway listener referencing a Secret that nothing ever creates — silently breaking TLS at runtime with no template error. Fail fast in wire-ingress.domains when an additional domain has neither cert-manager enabled nor a per-domain tls.secretName, pointing the operator at the two valid fixes (enable cert-manager, or supply a pre-created secret). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Multi-ingress (config.domains) serves one backend on several unrelated domains and is a niche single-customer setup; federation (federator.enabled) is the common case and is inherently single-domain. Supporting both together is out of scope, and the federator templates depend on config.dns, which is unset in multi-ingress mode. Rather than paper over that with a domain fallback, enforce the constraint: wire-ingress.domains fails fast when config.domains is combined with federator.enabled, with a guard also on certificate-federator.yaml for a clear message. Document the constraint in values.yaml and the README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jschaul
force-pushed
the
WPB-25475_Add-multi-ingress-support
branch
from
July 27, 2026 15:10
e29c581 to
9a808a1
Compare
jschaul
approved these changes
Jul 27, 2026
jschaul
left a comment
jschaul
left a comment
Member
There was a problem hiding this comment.
Good enough to try out I would say.
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://wearezeta.atlassian.net/browse/WPB-25475
Adds multi-domain support to the wire-ingress (Envoy Gateway) chart.
Set config.domains (a list) instead of the scalar config.dns to serve several backend domains from one release. You designate one domain as the primary; each additional domain gets its own Gateway listener, certificate, suffixed HTTPRoutes, and an injected per-domain CSP header (replacing the old nginx renderCSPInIngress). federator stays single-domain.
Backwards compatible: with config.dns (no config.domains), output is unchanged.
Checklist
changelog.d