Skip to content

WPB-26771: deprecate meetingsPremium feature flag - #5326

Merged
blackheaven merged 9 commits into
developfrom
gdifolco/WPB-26771-drop-meetingPremium
Jul 8, 2026
Merged

WPB-26771: deprecate meetingsPremium feature flag#5326
blackheaven merged 9 commits into
developfrom
gdifolco/WPB-26771-drop-meetingPremium

Conversation

@blackheaven

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-26771

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven
blackheaven requested review from a team as code owners July 7, 2026 17:03
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 7, 2026
@blackheaven
blackheaven force-pushed the gdifolco/WPB-26771-drop-meetingPremium branch from a1a2b8a to 8ed7adb Compare July 7, 2026 17:08
The meetingsPremium flag no longer affects meeting behaviour: team meetings
are always non-trial; only personal (non-team) users create trial meetings.
The MeetingsPremiumConfig type now defaults to enabled/locked and carries a
DEPRECATED pragma; the type, its public/internal endpoints and the feature
flag CRUD tests are retained for API compatibility and scheduled for removal.

Drops the meetingsPremium override from helm charts (values.yaml, galley
configmap, helm_vars gotmpl) and galley.integration.yaml so the code default
(enabled/locked) applies uniformly. Adds -Wno-deprecations to the modules
that still reference the retained type.
@blackheaven
blackheaven force-pushed the gdifolco/WPB-26771-drop-meetingPremium branch from 8ed7adb to 70d38d8 Compare July 7, 2026 17:19
Comment thread changelog.d/2-features/wpb-26771-meetings-premium.md Outdated
Comment thread changelog.d/2-features/wpb-26771-meetings-premium.md Outdated
Comment thread integration/test/Test/Meetings.hs Outdated
Comment thread integration/test/Test/Meetings.hs Outdated
@@ -1,4 +1,5 @@
{-# LANGUAGE PartialTypeSignatures #-}
{-# OPTIONS_GHC -Wno-deprecations #-}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you won't forget to clean these flags up once the feature flag is finally deleted?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope too :/

blackheaven and others added 2 commits July 8, 2026 17:28
@blackheaven
blackheaven requested a review from supersven July 8, 2026 15:33

@supersven supersven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@blackheaven
blackheaven merged commit cb1b4fa into develop Jul 8, 2026
11 checks passed
@blackheaven
blackheaven deleted the gdifolco/WPB-26771-drop-meetingPremium branch July 8, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants