Stabilize testSparScimCreateGetSearchUserGroup - #5331
Merged
supersven merged 1 commit intoJul 10, 2026
Conversation
zebot
added
the
ok-to-test
The order of members in a SCIM group doesn't matter and exists only accidentally; because JSON has no notion of sets. So, ordering members' list entries by their `Ord` instance leads to stable comparisons.
supersven
force-pushed
the
sventennie/deflake-testSparScimCreateGetSearchUserGroup
branch
from
July 10, 2026 12:44
f4d8150 to
5c7d371
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the SCIM group integration test by normalizing JSON values before comparison so that accidental array ordering (notably group members) does not cause flaky test failures.
Changes:
- Added a
normalizeValuehelper that recursively sorts all JSON arrays to produce a canonical form for comparisons. - Updated
testSparScimCreateGetSearchUserGroupassertions to compare normalized JSON (single-group fetch + bulk search results). - Added
Data.Vectorimport to support array reconstruction during normalization.
supersven
marked this pull request as ready for review
July 10, 2026 13:03
blackheaven
approved these changes
Jul 10, 2026
supersven
deleted the
sventennie/deflake-testSparScimCreateGetSearchUserGroup
branch
July 10, 2026 13:41
supersven
added a commit
that referenced
this pull request
Jul 14, 2026
The order of members in a SCIM group doesn't matter and exists only accidentally; because JSON has no notion of sets. So, ordering members' list entries by their `Ord` instance leads to stable comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of members in a SCIM group doesn't matter and exists only accidentally; because JSON has no notion of sets.
So, ordering members' list entries by their
Ordinstance leads to stable comparisons.Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d