WPB-23896: address SonarQube findings - #5332
Merged
Merged
Conversation
- Add automountServiceAccountToken: false to 9 auxiliary/test Helm chart pods that don't need K8s API access (elasticsearch-ephemeral, calling-test, demo-smtp, backoffice, fake-aws-ses/sns/sqs, outlook-addin, openldap) - Pin cachix/install-nix-action to full commit SHA (v16 -> d56f3ce9be45c562799280e8a561fbbe8f36de44) - Add @functools.total_ordering to frozendict (S8500: missing comparison methods)
zebot
added
the
ok-to-test
battermann
approved these changes
Jul 10, 2026
battermann
left a comment
battermann
left a comment
Contributor
There was a problem hiding this comment.
Given automountServiceAccountToken=false is what we want (I am not familiar with it) it looks all good to me.
Contributor
Author
|
I may be wrong, but we do not use it in our code generally |
Contributor
Yeah, makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23896
Checklist
changelog.d